Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCF Python 3.7 backwards-compatible logging #131

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Update GCF Python 3.7 backwards-compatible logging #131

merged 2 commits into from
Jun 1, 2021

Conversation

asriniva
Copy link
Contributor

Fixes issues in backwards compatibility for GCF Python 3.7.

@google-cla google-cla bot added the cla: yes label May 27, 2021
@asriniva asriniva requested a review from di May 27, 2021 23:56
di
di reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we add a test to demonstrate the use case this is designed to fix.

@asriniva asriniva requested a review from di June 1, 2021 22:25
@asriniva asriniva merged commit b46c12b into GoogleCloudPlatform:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asriniva @di