Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional fields to Marketplace launch page #317

Closed
swilliams11 opened this issue Sep 17, 2020 · 6 comments
Closed

Add Additional fields to Marketplace launch page #317

swilliams11 opened this issue Sep 17, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@swilliams11
Copy link
Contributor

The Datashare product has some new properties that should be included by the user.

The environment variables that must be set on the UI application when it is deployed to Cloud Run are shown below. These should be set in the UI's Cloud Build function.

{
  "VUE_APP_API_BASE_URL": "DOMAIN_NAME",
  "VUE_APP_PROJECT_ID": "PROJECT_ID",
  "VUE_APP_GOOGLE_APP_CLIENT_ID": "CLIENT_ID"
}
  1. The domain name setup should be completed as part of the prerequisites. This can be a required field or optional field. If it is optional, then the customer must complete this step after the deployment is completed.
  • Append /v1alpha to the provided domain name
  1. The project ID is already available in the Deployment Manager so we can auto-populate this environment variable.

  2. The client ID must be a new required field on the launch page.

@swilliams11 swilliams11 self-assigned this Sep 17, 2020
@mservidio
Copy link
Contributor

Also for the API, we need to set the env variable: UI_BASE_URL.

@mservidio
Copy link
Contributor

We should also apply the ISTIO policies at this point, as we will have all of the necessary variables to do so.

@swilliams11 swilliams11 added the enhancement New feature or request label Sep 24, 2020
@swilliams11
Copy link
Contributor Author

Make sure to include the full name here for UI_BASE_URL
https://domainname.com

@swilliams11
Copy link
Contributor Author

VUE_APP_API_BASE_URL=https://api.datashare-domain.com/v1alpha

@swilliams11
Copy link
Contributor Author

When a user enters a UI domain name (domainname.com) then the following API is deployed with the following environment variable.
image

When a user enters a UI domain name as https://datashare.com
image

When a user enters a UI domain name as http://datashare.com
image

If the UI domain name is not included by the user, then the environment variable will not be included on the API.
image

@swilliams11
Copy link
Contributor Author

API domain name

When a user enters http://api.datashare.com, then the deployment fails immediately.
image

When user enters https://api.domain.com, then
image
image

When user enters api.domain.com, then
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants