Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Increase threadpool count to avoid deadlocks #1391

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix: Increase threadpool count to avoid deadlocks #1391

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
257fca6
fix: Increase threadpool count to avoid deadlock and reduce forceRefr…
hessjcg Jul 18, 2023
9f05659
chore: better code comments.
hessjcg Jul 18, 2023
60c9701
chore: better code comments.
hessjcg Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/main/java/com/google/cloud/sql/core/CoreSocketFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,14 @@ public static synchronized CoreSocketFactory getInstance() {
@VisibleForTesting
// Returns a listenable, scheduled executor that exits upon shutdown.
static ListeningScheduledExecutorService getDefaultExecutor() {
// TODO(kvg): Figure out correct way to determine number of threads

// During refresh, each instance consumes 2 threads from the thread pool. By using 8 threads,
// there should be enough free threads so that there will not be a deadlock. Most users
// configure 3 or fewer instances, requiring 6 threads during refresh. By setting
// this to 8, it's enough threads for most users, plus a safety factor of 2.
ScheduledThreadPoolExecutor executor =
(ScheduledThreadPoolExecutor) Executors.newScheduledThreadPool(2);
(ScheduledThreadPoolExecutor) Executors.newScheduledThreadPool(8);
enocom marked this conversation as resolved.
Show resolved Hide resolved

executor.setExecuteExistingDelayedTasksAfterShutdownPolicy(false);
return MoreExecutors.listeningDecorator(
MoreExecutors.getExitingScheduledExecutorService(executor));
Expand Down