Ensure one-time event listeners only run once #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
approved these changes
Oct 2, 2024
tunetheweb
approved these changes
Oct 3, 2024
| handle = rIC(cb); | ||
| onHidden(cb); | ||
| rIC(cb); | ||
| document.addEventListener('visibilitychange', cb, {once: true}); |
There was a problem hiding this comment.
【discuss】why the cb should be called two times？
- when it's hidden：call it once，immediately
- when it's visible：call it once with rIC and another time when change to hidden
before the change，it‘s wrapped with runOnce will only call once
There was a problem hiding this comment.
Thanks for catching this! I've created to #541 to address this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534.
This PR removes the
onHidden()utility in favor of manually usingvisibilitychangelisteners, which gives more control over adding listeners that just need to run once.