-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(tsc): fix audit details type hierarchy #7177
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,6 +159,7 @@ class BootupTime extends Audit { | |
|
||
const summary = {wastedMs: totalBootupTime}; | ||
|
||
/** @type {LH.Audit.Details.Table['headings']} */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. had to add a ton of these explicit |
||
const headings = [ | ||
{key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)}, | ||
{key: 'total', granularity: 1, itemType: 'ms', text: str_(UIStrings.columnTotal)}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,7 +67,11 @@ class Diagnostics extends Audit { | |
return { | ||
score: 1, | ||
rawValue: 1, | ||
details: {items: [diagnostics]}, | ||
details: { | ||
type: 'diagnostic', | ||
// TODO: Consider not nesting diagnostics under `items`. | ||
items: [diagnostics], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. awww this is just to remain non-breaking? :) the idea would be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ha, well, since we just added this and we consider it internal only, I'm happy to change, I just didn't want to assume and/or cause churn in people's lives, especially because i mostly don't use these :) We could change these newer ones and leave the older ones like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I meant "awwww" as in how thoughtful :D I'm probably the only person that relies on this and that would indeed be a pain, lol I like leaving them until v5 :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. haha, got it. SGTM :) |
||
}, | ||
}; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left undefined if these weren't defined to match current LHR behavior