Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(entity-classification): integrate public-suffix-list into LH #15641

Merged
merged 4 commits into from
Dec 1, 2023
Merged

core(entity-classification): integrate public-suffix-list into LH #15641

merged 4 commits into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. core(entity-classification): integrate public-suffix-list into LH 

    Experiments integrating npm:tldts (MIT licensed) to bring in
public suffix list based root domain classification.
Splits Util.getRootDomain into UrlUtils.getRootDomain that depends
on PSL, and replaces report-side with entity recognition based.
Preserves existing rootDomains with an explicit `Legacy` prefix
to be used for rendering pre-10.0 LHRs.
    @alexnj
    alexnj committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    182f299 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @alexnj
    alexnj committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2c03bd5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Paul Irish <paulirish@users.noreply.github.com>
    @alexnj @paulirish
    alexnj and paulirish committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a4ba369 View commit details
    Browse the repository at this point in the history

  4. Review changes + tests.

    @alexnj
    alexnj committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    a26f8bc View commit details
    Browse the repository at this point in the history