Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(uses-http2): include multiplexable assets when 1p is a known 3p origin #15638

Merged
merged 3 commits into from
Dec 5, 2023
Merged

core(uses-http2): include multiplexable assets when 1p is a known 3p origin #15638

merged 3 commits into from
Dec 5, 2023

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Nov 29, 2023

Fixes #14661.

  • Renames isStaticAsset to isMultiplexableStaticAsset.
  • Adds a test to cover the scenario of 1P origin being a recognizable 3P entity.

@alexnj alexnj requested a review from a team as a code owner November 29, 2023 00:25
@alexnj alexnj requested review from adamraine and removed request for a team November 29, 2023 00:25
@connorjclark connorjclark changed the title core(uses-http2): dont skip multiplexable assets when 1st party is a recognizable 3p origin core(uses-http2): dont skip multiplexable assets when 1p is a recognizable 3p origin Dec 4, 2023
@connorjclark connorjclark changed the title core(uses-http2): dont skip multiplexable assets when 1p is a recognizable 3p origin core(uses-http2): include multiplexable assets when 1p is a recognizable 3p origin Dec 4, 2023
@connorjclark connorjclark changed the title core(uses-http2): include multiplexable assets when 1p is a recognizable 3p origin core(uses-http2): include multiplexable assets when 1p is a known 3p origin Dec 4, 2023
@alexnj alexnj merged commit 4c5e1c2 into main Dec 5, 2023
29 checks passed
@alexnj alexnj deleted the http2-fix branch December 5, 2023 22:54
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP/2 audit skips recommendations for known third-parties, in first-party context
3 participants
@alexnj @adamraine @devtools-bot