-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new_audit: third-party cookies #15632
Conversation
888606a
to
a62a9a1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
displayValue: '1 cookie found', | ||
details: { | ||
items: [ | ||
{name: 'Foo', url: /^http:\/\/\[::1\]:10503\/dobetterweb\/empty_module\.js/}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should make a literalToRegexStartsWith('https://.....')
....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new RegExp
will escape all of the /
for us but not the [
. Eh too much thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"headings": [], | ||
"items": [] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update artifacts to populate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, bit of noise in the sample changes but not too bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: I reverted this change because we will need to regen the DT log as well to prevent some subtle errors. I think the smoke test is sufficient until we do full artifacts regen.
This was discussed internally on email chain. Wasn't too much work to create a prototype so here it is.
Technically we already surface these issues via the generic inspector issues audit alongside all the other cookie issues. However, specific information about each issue is missing and the call to action is just opening the issues panel for more info.
This audit will make 3PCD issues much more visible with a direct link to better documentation.