core: do not emit NOT_HTML error if record not ok #15271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Jul 14, 2023
| @@ -95,6 +95,9 @@ function getNonHtmlError(finalRecord) { | |||
| // If we never requested a document, there's no doctype error, let other cases handle it. | |||
| if (!finalRecord) return undefined; | |||
|
|
|||
| // If the document request error'd, we should not complain about a bad mimeType. | |||
| if (!finalRecord.mimeType || finalRecord.statusCode === -1) return undefined; | |||
There was a problem hiding this comment.
Shouldn't we emit a different error in this case instead of returning no error?
There was a problem hiding this comment.
So ideally when this occurs, the networkError would be what getPageLoadError returns.
For some reason in LR that wasn't happening. The mainRecord (redirected) failed, yet we didn't emit a network error type.
The fallback in this case is a generic navigationError. So in isolation, this function returning nothing when there is no mimeType-specific error is consistent with the error pattern used here.
adamraine
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15270