core: remove legacy runner #15253
Merged
core: remove legacy runner #15253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Jul 12, 2023
| expect(await gatherer.beforePass(fakeParam)).toBe(undefined); | ||
| expect(await gatherer.pass(fakeParam)).toBe(undefined); | ||
| expect(await gatherer.afterPass(fakeParam, fakeParam)).toBe(undefined); | ||
| }); |
There was a problem hiding this comment.
After removing the legacy beforePass/afterPass stuff this test file really isn't testing anything. The base gatherer gets plenty of test coverage from other files.
adamraine
commented
Jul 12, 2023
| @@ -7,15 +7,12 @@ | |||
| import jestMock from 'jest-mock'; | |||
|
|
|||
| import ImageElements from '../../../gather/gatherers/image-elements.js'; | |||
| import {NetworkRecorder} from '../../../lib/network-recorder.js'; | |||
| import {createMockContext, createMockDriver, createMockSession} from | |||
There was a problem hiding this comment.
I recommend disabling whitespace changes to review this file
adamraine
commented
Jul 12, 2023
| @@ -24,7 +24,6 @@ import { | |||
| renderHtmlInIframe, | |||
| selectCategories, | |||
| selectDevice, | |||
| setLegacyNavigation, | |||
There was a problem hiding this comment.
I recommend reviewing this file with whitespace changes off
adamraine
commented
Jul 13, 2023
| * Legacy property used to define the artifact ID. In Fraggle Rock, the artifact ID lives on the config. | ||
| * @return {keyof LH.GathererArtifacts} | ||
| */ | ||
| get name() { |
There was a problem hiding this comment.
Could have kept this for convenience, but since it requires some substr hackery just to work with rollup I figured it's best not to rely on it if we don't have to.
connorjclark
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest, baddest part of #15060 that's 3 years in the making.
There are a few follow-up changes we should make once this lands:
FRTransitional.../FRThis/FRThattypes