Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(network-recorder): set target type of unfinished request #15232

Merged
merged 1 commit into from
Jul 7, 2023
Merged

core(network-recorder): set target type of unfinished request #15232

merged 1 commit into from
Jul 7, 2023

Conversation

adamraine
Copy link
Member

Investigated some flaky oopif-requests failures:
https://github.com/GoogleChrome/lighthouse/actions/runs/5489241604/jobs/10003149170?pr=15231

If a request only has a Network.requestWillBeSent event we will still create a request for it, but we were not setting the sessionTargetType for that initial request.

@adamraine adamraine requested a review from a team as a code owner July 7, 2023 19:40
@adamraine adamraine requested review from brendankenny and removed request for a team July 7, 2023 19:40
connorjclark
connorjclark approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@adamraine adamraine merged commit 7c5f223 into main Jul 7, 2023
29 checks passed
@adamraine adamraine deleted the target-type-unfinished branch July 7, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny brendankenny is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamraine @connorjclark