Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move metric savings to audit product #15074

Merged
merged 6 commits into from
May 18, 2023
Merged

Conversation

adamraine
Copy link
Member

Original approach was flawed (see #15071)

@adamraine adamraine requested a review from a team as a code owner May 12, 2023 16:18
@adamraine adamraine requested review from connorjclark and removed request for a team May 12, 2023 16:18

// [EXPERIMENTAL] Estimates of how much this audit affects various performance
// metrics. Values will be in the unit of the respective metrics.
google.protobuf.Struct _metricSavings = 13;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is renaming this to metricSavings going to cause issues down the line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just not include it in the proto yet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(otherwise it's my understanding that it'll have to ship in the proto forever, just not be populated anymore)

@brendankenny
Copy link
Member

I didn't realize in #15071 (comment) that it wasn't on the actual audit result in the LHR, just on the intermediate audit product. Maybe the current way is the best way to land these, since we don't have to worry about them exposed in the LHR at all yet?

@adamraine
Copy link
Member Author

adamraine commented May 12, 2023

Protobuf seems to be having issues with the leading _ :/

We may need to remove the _ prefix, or we could keep these values out of the LHR for now.

@adamraine adamraine merged commit 7976210 into main May 18, 2023
@adamraine adamraine deleted the metric-savings-on-product branch May 18, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants