Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(lantern-collect): rebaseline to include new ttfb metric #15069

Merged
merged 2 commits into from
May 11, 2023

Conversation

connorjclark
Copy link
Collaborator

follow up to #14941

@connorjclark connorjclark requested a review from a team as a code owner May 11, 2023 23:06
@connorjclark connorjclark requested review from brendankenny and removed request for a team May 11, 2023 23:06
@@ -1,81 +1,81 @@
{
"sites": [
{"url": "http://m.iciba.com", "roughEstimateOfFCP": 1743, "optimisticFCP": 1743, "pessimisticFCP": 1743, "roughEstimateOfFMP": 1743, "optimisticFMP": 1743, "pessimisticFMP": 1743, "roughEstimateOfTTI": 7517, "optimisticTTI": 3337, "pessimisticTTI": 11697, "roughEstimateOfSI": 9842, "optimisticSI": 4764, "pessimisticSI": 5264, "roughEstimateOfLCP": 9781, "optimisticLCP": 9341, "pessimisticLCP": 10222},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this PR because I noticed a delta in this file when running node core/scripts/lantern/update-baseline-lantern-values.js. It was simply the new TTFB metric being added (nothing else changed, as expected). The other metrics do not show up yet because the necessary data in the trace is missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why is TTFB added but not LCP load start/end? I would imagine that none of the sites had a baseline TTFB before now.

Copy link
Collaborator Author

@connorjclark connorjclark May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's likely no DOMNodeId in these old traces, so LCPImageRecord will fail to determine load start/end.

ttfb doesn't rely on any new trace stuff. so when the lantern baseline values are updated, all the data is there to compute it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, they don't even have LargestImagePaint::Candidate events :P

@@ -243,6 +243,11 @@ evaluateAndPrintAccuracy('largestContentfulPaint', 'optimisticLCP');
evaluateAndPrintAccuracy('largestContentfulPaint', 'pessimisticLCP');
evaluateAndPrintAccuracy('largestContentfulPaint', 'roughEstimateOfLCP');

// TODO: enable when new traces are collected (also, do calls to findAndPrintWorst10Sites)
// evaluateAndPrintAccuracy('timeToFirstByte', 'roughEstimateOfTTFB');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving future us some time here

@connorjclark connorjclark merged commit 49aa142 into main May 11, 2023
@connorjclark connorjclark deleted the update-lantern-baseline-ttfb branch May 11, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants