core: use main-frame LCP trace element #14760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the
s/processedNavigation.largestContentfulPaintEvt/processedNavigation.largestContentfulPaintAllFramesEvt
from #14695 and goes back to getting the LCP element from the main frame. Was not a bug, since that's where the LCP value comes from too.Also added some comments and assertions to the frames smoke test for the next time I look at these lines and wonder, "wait, why aren't we looking at the all-frames LCP?".