core(third-party-summary): change item.entity from link to text #14749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed! Hopefully the one channel that has staying-power (DevTools) won't be impacted, if we can get a 10.1 out in time. |
connorjclark
reviewed
Feb 3, 2023
connorjclark
approved these changes
Feb 4, 2023
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out Third-Party-Summary deprecation changes from #14655, if we need to defer grouping changes to 10.1.
The audit uses a
LinkValuedata type on itsentitycolumn. This deprecates the usage of thatvalueTypeand converts it intotext. The value will be the name of the entity, correlatable to entity names inLHR.entities.This will render Third-Party-Summary audit's heading rows as text (currently they are clickable URLs that lead to 3P's homepage, if one is available). This seems a minor breakage that we could live with until 10.1 where tables would feature a clickable adornment, but still worth calling out.