Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: refactor out entity-classification lookup tables #14744

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

alexnj
Copy link
Member

@alexnj alexnj commented Feb 2, 2023

Drops the two lookup tables and firstParty: string from entity classification, rendering it to be a flat list of entities. Origins are now packed in entity.origins: Array<string>.

@alexnj alexnj requested a review from a team as a code owner February 2, 2023 00:46
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

types/lhr/lhr.d.ts Outdated Show resolved Hide resolved
report/renderer/report-utils.js Outdated Show resolved Hide resolved
core/runner.js Outdated Show resolved Hide resolved
@alexnj alexnj merged commit bdbc91b into main Feb 2, 2023
@alexnj alexnj deleted the entity-nolookup-tables branch February 2, 2023 01:30
@ftservice ftservice linked an issue Feb 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone
4 participants