Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix issues found in some strings from localizers #14740

Merged
merged 2 commits into from
Jan 31, 2023
Merged

misc: fix issues found in some strings from localizers #14740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
970afe0
misc: fix issues found in some strings from localizers
connorjclark Jan 31, 2023
72e77db
test
connorjclark Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/audits/dobetterweb/doctype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ const UIStrings = {
'[Learn more about the doctype declaration](https://developer.chrome.com/docs/lighthouse/best-practices/doctype/).',
/** Explanatory message stating that the document has no doctype. */
explanationNoDoctype: 'Document must contain a doctype',
/** Explanatory message stating that the document has wrong doctype */
explanationWrongDoctype: 'Document contains a doctype that triggers quirks-mode',
/** Explanatory message stating that the document has wrong doctype */
explanationLimitedQuirks: 'Document contains a doctype that triggers limited-quirks-mode',
/** Explanatory message stating that the document has wrong doctype that triggers `quirks-mode` */
explanationWrongDoctype: 'Document contains a `doctype` that triggers `quirks-mode`',
/** Explanatory message stating that the document has wrong doctype that triggers `limited-quirks-mode` */
explanationLimitedQuirks: 'Document contains a `doctype` that triggers `limited-quirks-mode`',
/** Explanatory message stating that the publicId field is not empty. */
explanationPublicId: 'Expected publicId to be an empty string',
/** Explanatory message stating that the systemId field is not empty. */
Expand Down
2 changes: 1 addition & 1 deletion core/lib/bf-cache-strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ const UIStrings = {
* @description Description text for not restored reason InjectedJavascript.
*/
injectedJavascript:
'IPages that JavaScript is injected into by extensions are not currently eligible for back/forward cache.',
'Pages that JavaScript is injected into by extensions are not currently eligible for back/forward cache.',
/**
* @description Description text for not restored reason InjectedStyleSheet.
*/
Expand Down
2 changes: 2 additions & 0 deletions core/scripts/i18n/collect-strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,8 @@ function checkKnownFixedCollisions(strings) {
'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
'Document contains a $MARKDOWN_SNIPPET_0$ that triggers $MARKDOWN_SNIPPET_1$',
'Document contains a $MARKDOWN_SNIPPET_0$ that triggers $MARKDOWN_SNIPPET_1$',
'Document has a valid $MARKDOWN_SNIPPET_0$',
'Document has a valid $MARKDOWN_SNIPPET_0$',
'Failing Elements',
Expand Down
4 changes: 2 additions & 2 deletions core/test/audits/dobetterweb/doctype-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('DOBETTERWEB: doctype audit', () => {
});
assert.equal(auditResult.score, 0);
expect(auditResult.explanation)
.toBeDisplayString('Document contains a doctype that triggers quirks-mode');
.toBeDisplayString('Document contains a `doctype` that triggers `quirks-mode`');
});

it('fails when document is in limited-quirks-mode', () => {
Expand All @@ -47,7 +47,7 @@ describe('DOBETTERWEB: doctype audit', () => {
});
assert.equal(auditResult.score, 0);
expect(auditResult.explanation)
.toBeDisplayString('Document contains a doctype that triggers limited-quirks-mode');
.toBeDisplayString('Document contains a `doctype` that triggers `limited-quirks-mode`');
});

it('fails when the value of the name attribute is a value other than "html"', () => {
Expand Down
6 changes: 3 additions & 3 deletions shared/localization/locales/en-US.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions shared/localization/locales/en-XL.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.