core: remove util.cjs #14703
Merged
core: remove util.cjs #14703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
brendankenny
and removed request for
a team
connorjclark
commented
Jan 24, 2023
adamraine
reviewed
Jan 24, 2023
shared/util.js
Outdated
| @@ -832,7 +449,7 @@ const UIStrings = { | |||
| /** Label indicating that Lighthouse throttled the page using custom throttling settings. */ | |||
| runtimeCustom: 'Custom throttling', | |||
| }; | |||
| Util.UIStrings = UIStrings; | |||
There was a problem hiding this comment.
These strings look specific to the report renderer. Would it make more sense for them to live in ReportUtils?
There was a problem hiding this comment.
Made this change, but it required not initializing strings as a copy of UIStrings since that made a cyclic dependency between report-utils.js and report-globals.js. Only matter for test code, which had to be updated.
I then saw a nice cleanup to the globals to provide a apply function to set them all up.
adamraine
reviewed
Jan 24, 2023
adamraine
approved these changes
Jan 25, 2023
|
|
||
| const {document} = new jsdom.JSDOM().window; | ||
| dom = new DOM(document); | ||
| detailsRenderer = new DetailsRenderer(dom); | ||
| }); | ||
|
|
||
| after(() => { | ||
| Util.i18n = undefined; | ||
| Globals.i18n = undefined; |
There was a problem hiding this comment.
WDYT about a Globals.clear()?
There was a problem hiding this comment.
since it'd be just for tests - nah
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(first attempt: #14378)