Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: use entity classification to filter third-parties #14697

Merged
merged 143 commits into from
Jan 27, 2023
Merged

report: use entity classification to filter third-parties #14697

merged 143 commits into from
Jan 27, 2023

Commits on Oct 20, 2022

  1. First cut of entity classification computed artifact.

    @alexnj
    alexnj committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    7833354 View commit details
    Browse the repository at this point in the history

  2. some cleanup on the types

    @alexnj
    alexnj committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0a154eb View commit details
    Browse the repository at this point in the history

  3. Refactor resource-summary audit with third party classification

    @alexnj
    alexnj committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    3212aa6 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Refactor unused-javascript to output entity and is-3p flag

    @alexnj
    alexnj committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    c71a8ab View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Refactor 3p audits to depend on computed entity classification.

    @alexnj
    alexnj committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    14163bd View commit details
    Browse the repository at this point in the history

  2. Expose entity classification to LH report via a hidden audit.

    @alexnj
    alexnj committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    46d706c View commit details
    Browse the repository at this point in the history

  3. Refine groupBy feature to be more concise.

    @alexnj
    alexnj committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b5caa4f View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Replace domains with homepage

    @alexnj
    alexnj committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8689903 View commit details
    Browse the repository at this point in the history

  2. Revert the LHR grouping changes, after discussing the design with team.

    @alexnj
    alexnj committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    5b67f2e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Add name based lookup to entity classification audit result.

    @alexnj
    alexnj committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0abc053 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Refactor third-party filter to base on entity-classification

    @alexnj
    alexnj committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    170adcb View commit details
    Browse the repository at this point in the history

  2. Attach entity classification to ByteEfficiencyAudit.

    @alexnj
    alexnj committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    5e18f75 View commit details
    Browse the repository at this point in the history

  3. Classify bootup-time (Reduce JavaScript execution time) audit

    @alexnj
    alexnj committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    f0674c7 View commit details
    Browse the repository at this point in the history

  4. Classify long-tasks (Avoid long main-thread tasks) audit

    @alexnj
    alexnj committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    69725b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Classify uses-long-cache-ttl audit.

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ab5d847 View commit details
    Browse the repository at this point in the history

  2. Mark sub-items with entity as well

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    04bfff8 View commit details
    Browse the repository at this point in the history

  3. Fix the regression caused to third-party-summary audit

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    e8c1c7e View commit details
    Browse the repository at this point in the history

  4. Classify uses-rel-preconnect audit.

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0a87d78 View commit details
    Browse the repository at this point in the history

  5. Classify all ViolationAudit derived audits.

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d953829 View commit details
    Browse the repository at this point in the history

  6. Classify no-unload-listeners audit

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    aea71bf View commit details
    Browse the repository at this point in the history

  7. Classify total-byte-weight audit

    @alexnj
    alexnj committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    cb16f02 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    1e73c13 View commit details
    Browse the repository at this point in the history

  2. Updated components/CSS

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e79f44b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6f80513 View commit details
    Browse the repository at this point in the history

  4. Some cleanup

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    d299ae8 View commit details
    Browse the repository at this point in the history

  5. Classify valid-source-maps audit

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    f462dc8 View commit details
    Browse the repository at this point in the history

  6. Classify legacy-javascript audit

    @alexnj
    alexnj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    9189494 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Classify all audits that depend on makeOpportunityDetails call

    @alexnj
    alexnj committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f1d9893 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1ad67ac View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Explicitly name the lookup tables.

    @alexnj
    alexnj committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0230896 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Update types on entity classification

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    abf81f9 View commit details
    Browse the repository at this point in the history

  2. Update unit tests of ViolationAudit based tests.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    73cc72d View commit details
    Browse the repository at this point in the history

  3. Unit tests: Legacy Javascript and Bootup Time.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1daccab View commit details
    Browse the repository at this point in the history

  4. Fix the bug introduced into firstPartyHostname calculation.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8cd7347 View commit details
    Browse the repository at this point in the history

  5. Bugfix: Rely on Artifacts.URL.mainDocumentUrl for 1P calc.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4a44dc6 View commit details
    Browse the repository at this point in the history

  6. Classify and update unit tests of 3P facades audit.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    60c609a View commit details
    Browse the repository at this point in the history

  7. Unit tests for 3p facades test.

    @alexnj
    alexnj committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    39753fe View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. First party detection should fall back to finalDisplayedUrl.

    @alexnj
    alexnj committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    0459e38 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Update third-party-summary tests.

    @alexnj
    alexnj committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a9e5d6a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Allow audits to override entity on items.

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f7adfe3 View commit details
    Browse the repository at this point in the history

  2. update tests for valid-source-maps

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    21a53ba View commit details
    Browse the repository at this point in the history

  3. Update snapshots + flow

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    da02b4f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8780384 View commit details
    Browse the repository at this point in the history

  5. Make third-party filtering backward compatible to old LHRs.

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    880c09e View commit details
    Browse the repository at this point in the history

  6. Remove extra space

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    86fc747 View commit details
    Browse the repository at this point in the history

  7. Unit tests for Audit.makeOpportunityDetails

    @alexnj
    alexnj committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    122486e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Updated tests cases set.

    @alexnj
    alexnj committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d14d703 View commit details
    Browse the repository at this point in the history

  2. Updated tests set.

    @alexnj
    alexnj committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ac3f59e View commit details
    Browse the repository at this point in the history

  3. Remove redundant entity marker.

    @alexnj
    alexnj committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d373c45 View commit details
    Browse the repository at this point in the history

  4. some minor fixups.

    @alexnj
    alexnj committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    171d563 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Entity classification unit tests.

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1059e6a View commit details
    Browse the repository at this point in the history

  2. Computed entity-classification artifact unit tests.

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ad43021 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    02f212a View commit details
    Browse the repository at this point in the history

  4. Fix navigation and timespan E2E audit counts.

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    99a9a67 View commit details
    Browse the repository at this point in the history

  5. Explicitly handle entity-classification details.type

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    793b1ae View commit details
    Browse the repository at this point in the history

  6. Shorter explanation for tsc-expect-error

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6eef166 View commit details
    Browse the repository at this point in the history

  7. apparently i cant see squiggly lines

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2667564 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    36bff06 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Review fixes

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2f50be6 View commit details
    Browse the repository at this point in the history

  2. Refactor entity-classification to shed LUT/lookup tables.

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    093d60c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into entity-based-3p

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9e29828 View commit details
    Browse the repository at this point in the history

  4. Reverse all but entity-classification auditis change.

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c3efb66 View commit details
    Browse the repository at this point in the history

  5. third-party-facades depend on third-party-summary so it needs ec.

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    49bce13 View commit details
    Browse the repository at this point in the history

  6. Bring branch in sync and tests passing.

    @alexnj
    alexnj committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    388e557 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Now that we need to lookup on the report, bring back LUTs.

    @alexnj
    alexnj committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    42cb558 View commit details
    Browse the repository at this point in the history

  2. Compute entities during reporting, first pass.

    @alexnj
    alexnj committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    932b029 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Sync review changes from entity-based-3p branch: 2022-12-21 11:04

    @alexnj
    alexnj committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8ebe3d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Move entity-classification from being an audit to global.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    4c9d8be View commit details
    Browse the repository at this point in the history

  2. Final review change sync from entity-based-3p at 2023-01-09 20:47

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    b57fb8e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into entity-based-3p-reportonly

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    730705a View commit details
    Browse the repository at this point in the history

  4. Move item.entity resolution to prepareReportResult

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    673162a View commit details
    Browse the repository at this point in the history

  5. Cant have esm fast enough

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    d3a68c7 View commit details
    Browse the repository at this point in the history

  6. Update tests.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    38bf2f7 View commit details
    Browse the repository at this point in the history

  7. Protobuf changes to support entityClassification.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6cba854 View commit details
    Browse the repository at this point in the history

  8. Some cleanup and comments.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a839ecc View commit details
    Browse the repository at this point in the history

  9. Make valid-source-maps audit depend on EntityClassification.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0224365 View commit details
    Browse the repository at this point in the history

  10. Drop entity classification from valid source maps audit

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    5304284 View commit details
    Browse the repository at this point in the history

  11. Add a test case to prevent unrecognized 3ps becoming 1ps

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e328f66 View commit details
    Browse the repository at this point in the history

  12. legacy-javsacript needs to depend on ComputedEntityClassification

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c31aca9 View commit details
    Browse the repository at this point in the history

  13. uses-http2 to depend on entity-classification

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f54852d View commit details
    Browse the repository at this point in the history

  14. Depend on entity classification adjust condition for correctness

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2934c84 View commit details
    Browse the repository at this point in the history

  15. Less hurting to the eyes.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    737fdd0 View commit details
    Browse the repository at this point in the history

  16. Revert uses-http2 logic change.

    @alexnj
    alexnj committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a3ca3e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Special case handling: source-location type

    @alexnj
    alexnj committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    608fe9e View commit details
    Browse the repository at this point in the history

  2. Use source-location instead of hardcoding names

    @alexnj
    alexnj committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    aa0e54f View commit details
    Browse the repository at this point in the history

  3. Fix up report-ui-features test

    @alexnj
    alexnj committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    f70b5d3 View commit details
    Browse the repository at this point in the history

  4. missed the core/util

    @alexnj
    alexnj committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    39c441d View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Update url protocol check

    @alexnj
    alexnj committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    35ebe83 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into entity-based-3p-reportonly

    @alexnj
    alexnj committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0b82a99 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into entity-based-3p-reportonly

    @alexnj
    alexnj committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    dcabac8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    399a92a View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Connor Clark <cjamcl@google.com>
    @alexnj @connorjclark
    alexnj and connorjclark committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    145b9d5 View commit details
    Browse the repository at this point in the history

  2. Review changes.

    @alexnj
    alexnj committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    56d36ce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'entity-based-3p-reportonly' of github.com:GoogleChrome/… 

    …lighthouse into entity-based-3p-reportonly
    @alexnj
    alexnj committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    d11f3bb View commit details
    Browse the repository at this point in the history

  4. Update core/util

    @alexnj
    alexnj committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    f532bf7 View commit details
    Browse the repository at this point in the history

  5. Minor comment change

    @alexnj
    alexnj committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    811f103 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Review changes, deal with audit instead of params

    @alexnj
    alexnj committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    7971218 View commit details
    Browse the repository at this point in the history

  2. copy util

    @alexnj
    alexnj committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    47553d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Exclusion for some audits

    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    ca82fe3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7568caf View commit details
    Browse the repository at this point in the history

  3. Proto changes

    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    831fa7c View commit details
    Browse the repository at this point in the history

  4. Fix a bad merge

    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1ef0970 View commit details
    Browse the repository at this point in the history

  5. copy util

    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8b1a3a4 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8a87ec2 View commit details
    Browse the repository at this point in the history

  7. Unit test assertions for convenience fns.

    @alexnj
    alexnj committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    ebfa00d View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. exclude core/util.js from code coverage

    @alexnj
    alexnj committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    dba8d79 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    1fb6ad7 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Connor Clark <cjamcl@google.com>
    @alexnj @connorjclark
    alexnj and connorjclark committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    45b63b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Add back the correct type for Entity.

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    a1a293d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c08fb30 View commit details
    Browse the repository at this point in the history

  3. always missing core/util

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    157e3b5 View commit details
    Browse the repository at this point in the history

  4. Rename lookup tables to LH naming convention

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c6876d6 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Connor Clark <cjamcl@google.com>
    @alexnj @connorjclark
    alexnj and connorjclark committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    8d97490 View commit details
    Browse the repository at this point in the history

  6. add back legacy filter tests.

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c142ed6 View commit details
    Browse the repository at this point in the history

  7. Review changes: variable names

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    ded03b6 View commit details
    Browse the repository at this point in the history

  8. who likes commented tests?

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3b56d0b View commit details
    Browse the repository at this point in the history

  9. reverse patch all report changes.

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    656287c View commit details
    Browse the repository at this point in the history

  10. it's me vs. util.js time again

    @alexnj
    alexnj committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0a0136f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. review changes

    @alexnj
    alexnj committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    118f97d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into entity-based-3p-reportonly

    @alexnj
    alexnj committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    250d4f6 View commit details
    Browse the repository at this point in the history

  3. Relax checks on firstparty

    @alexnj
    alexnj committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    9c80a3e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    aec61da View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly
    @alexnj
    alexnj committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    11ec2b1 View commit details
    Browse the repository at this point in the history

  2. Collect all report related changes from #14622

    @alexnj
    alexnj committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e8760bb View commit details
    Browse the repository at this point in the history

  3. me vs. utiljs: utiljs:1, alex:0

    @alexnj
    alexnj committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    eeb341a View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    53d77a3 View commit details
    Browse the repository at this point in the history

  2. Cleanup after merge

    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a42dd62 View commit details
    Browse the repository at this point in the history

  3. util js is still leading!, alex: 0, coreutil: 2

    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    edbff41 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2d3c251 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c858df8 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    31c41ae View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
    @alexnj @adamraine
    alexnj and adamraine committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5e363d0 View commit details
    Browse the repository at this point in the history

  8. Review changes.

    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    dd8771c View commit details
    Browse the repository at this point in the history

  9. Update/cleanup comments

    @alexnj
    alexnj committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2cc6b44 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Review changes + Refactor of third-party filter + tests

    @alexnj
    alexnj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    6f392b8 View commit details
    Browse the repository at this point in the history

  2. delete core/util.cjs

    @alexnj
    alexnj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    2466ec6 View commit details
    Browse the repository at this point in the history

  3. Missed entity classification

    @alexnj
    alexnj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    8a6c2cc View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c2625a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Merge remote-tracking branch 'origin/main' into entity-based-3p-repor… 

    …tonly-extn
    @alexnj
    alexnj committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    f3a16d3 View commit details
    Browse the repository at this point in the history

  2. Update report/renderer/report-ui-features.js 

    Co-authored-by: Connor Clark <cjamcl@google.com>
    @alexnj @connorjclark
    alexnj and connorjclark committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    41aa773 View commit details
    Browse the repository at this point in the history

  3. attempt bugfix: unclassified row items aren't 3ps

    @alexnj
    alexnj committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e850f7e View commit details
    Browse the repository at this point in the history

  4. add testcase: non-classifable urls belong in 1st party.

    @alexnj
    alexnj committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1265edb View commit details
    Browse the repository at this point in the history

  5. Update report/renderer/report-ui-features.js 

    Co-authored-by: Connor Clark <cjamcl@google.com>
    @alexnj @connorjclark
    alexnj and connorjclark committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c69cb3d View commit details
    Browse the repository at this point in the history