deps: update to typescript 4.9.4 #14646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jan 3, 2023
| @@ -120,7 +120,7 @@ const mergeConfigFragment = _mergeConfigFragment; | |||
| * Merge an array of items by a caller-defined key. `mergeConfigFragment` is used to merge any items | |||
| * with a matching key. | |||
| * | |||
| * @template T | |||
| * @template {Record<string, any>} T | |||
| * @param {Array<T>|null|undefined} baseArray | |||
There was a problem hiding this comment.
btw, the mergeConfigFragment has a comment about doing the typing in config.d.ts because jsodc does not support constraints. it does now (hence this change), but I didn't go further than fixing errors that cropped up.
connorjclark
commented
Jan 3, 2023
report/renderer/topbar-features.js
Outdated
| } else { | ||
| // Note: FF implements both window.onbeforeprint and media listeners. However, | ||
| // it doesn't matchMedia doesn't fire when matching 'print'. | ||
| self.matchMedia('print').addListener(mql => { |
There was a problem hiding this comment.
narrowing supposedly got better, because self at this point was never.
adamraine
reviewed
Jan 3, 2023
| @@ -120,7 +120,7 @@ const mergeConfigFragment = _mergeConfigFragment; | |||
| * Merge an array of items by a caller-defined key. `mergeConfigFragment` is used to merge any items | |||
| * with a matching key. | |||
| * | |||
| * @template T | |||
There was a problem hiding this comment.
Could this be Record<string, unkown>?
There was a problem hiding this comment.
Not without further changes.
adamraine
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple upgrade, I only fixed errors. Did not assess new features.