Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: expose default and desktop configs on index.js #14543

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

adamraine
Copy link
Member

I think it would be useful to have these two at the top level api.

Ref #14048

@adamraine adamraine requested a review from a team as a code owner November 16, 2022 19:58
@adamraine adamraine requested review from brendankenny and removed request for a team November 16, 2022 19:58
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but can you explain the use case? This also came up when we were discussing lightrider-entry configs: extending the default configs is the express purpose of flags and the config extends field.

@adamraine
Copy link
Member Author

Having the desktop config in an accessible place is better than telling people to pull it in from lighthouse/core/config/desktop-config.js.

I can't think of a specific use case for having the default config exposed here, but there isn't a reason to not include it either.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We should finally make extends work with the other presets (desktop/perf/experimental, etc) and maybe even arbitrary extends config chains, but sounds good.

@adamraine adamraine merged commit 41821b8 into main Nov 18, 2022
@adamraine adamraine deleted the expose-configs-on-index branch November 18, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants