-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(network-request): backport rendererStartTime #14481
Conversation
/** When the renderer process initially discovers a network request. */ | ||
this.rendererStartTime = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still in seconds because everything else is without the rest of #14311
@@ -63,7 +63,8 @@ function getRequestWillBeSentEvent(networkRecord, index) { | |||
initialPriority: networkRecord.priority || 'Low', | |||
isLinkPreload: networkRecord.isLinkPreload, | |||
}, | |||
timestamp: networkRecord.redirectResponseTimestamp || networkRecord.startTime || 0, | |||
timestamp: networkRecord.redirectResponseTimestamp || networkRecord.rendererStartTime || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no test in this PR explicitly sets rendererStartTime
, but by default network-records-to-devtools-log
checks that round-tripping networkRecords->DevtoolsLog->networkRecords reproduces the input and some tests (like uses-http2
) use slightly altered but real network records that have an actual rendererStartTime
that now needs to make its way to the output
not sure what's up with the |
Yeah we update smokehouse to be more flexible with screenshot elements somewhere along the way. We can safely ignore those. |
backport of just what's needed to include
rendererStartTime
from #14311 in thenetwork-requests
hidden audit for richer timing information in the November HTTP Archive run.No other changes (or uses of
rendererStartTime
) included.