Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(user-flow): cleanup types #14442

Merged
merged 4 commits into from
Oct 21, 2022
Merged

core(user-flow): cleanup types #14442

merged 4 commits into from
Oct 21, 2022

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Oct 11, 2022 •
edited
Loading

  • Noticed we were exposing the static UserFlow object type not the instance type while testing core: restructure types for direct import and publishing #14441
  • HashState belongs on the flow report types, not the flow result types
  • lhr/flow.d.ts -> lhr/flow-result.d.ts
  • Config on the flow options should be optional
  • Jsdoc comments

@adamraine adamraine requested a review from a team as a code owner October 11, 2022 20:38
@adamraine adamraine requested review from connorjclark and removed request for a team October 11, 2022 20:38
@adamraine adamraine changed the title core(user-flow): expose instance type globally core(user-flow): cleanup types Oct 19, 2022
@adamraine adamraine merged commit 872d816 into main Oct 21, 2022
@adamraine adamraine deleted the user-flow-type branch October 21, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjclark connorjclark connorjclark approved these changes

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamraine @connorjclark @devtools-bot