cli: error early if --output-path is invalid #14367
Conversation
connorjclark
requested review from
brendankenny
and removed request for
a team
|
I feel like there's a super-ancient TODO about this that can maybe finally be deleted, but maybe it was already deleted... |
| * @return {string=} | ||
| */ | ||
| function coerceOutputPath(value) { | ||
| if (value === undefined) return; | ||
|
|
||
| if (typeof value !== 'string' || !fs.existsSync(path.dirname(value))) { | ||
| if (typeof value !== 'string' || !value || !fs.existsSync(path.dirname(value))) { |
There was a problem hiding this comment.
In what situation will value === undefined.
If it's the case where --output-path is provided without any value, could we do a different error message for that?
There was a problem hiding this comment.
In what situation will value === undefined.
when not provided. coerce is still called when param is not specified (or at least, it is for the "flags in a json path" case).
If it's the case where --output-path is provided without any value, could we do a different error message for that?
I think the current error is sufficient.
oh, ha, still no: Line 61 in 9acca3a humorously we'll create the path for |
fixes #14361