Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(trace-processor): refactor processEvents and frameEvents #14287

Merged
merged 46 commits into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
e489701
wip
paulirish Aug 9, 2022
42ded03
rendererids
paulirish Aug 9, 2022
b6c6296
trying things
paulirish Aug 10, 2022
36de69b
log shit
paulirish Aug 10, 2022
e6448e4
Merge branch 'processEventLog' into processEventsfix
paulirish Aug 10, 2022
7b8a6c1
i dig it..
paulirish Aug 10, 2022
189d568
processEvents good. frame and frameTree events now still broken
paulirish Aug 10, 2022
33da7cc
all event collections now including everything they should
paulirish Aug 10, 2022
751dafd
drop duplicate test name
paulirish Aug 10, 2022
5a0e31b
starting to remove framecommitted requirement
paulirish Aug 10, 2022
e283d76
test: reformat trace fixtures
paulirish Aug 10, 2022
669806e
update lcpAllFrames expectations.
paulirish Aug 11, 2022
e04b242
finishing up my frame investigation
paulirish Aug 11, 2022
e741b82
drop a bunch of noise from my branch
paulirish Aug 11, 2022
ea88628
tests are happy
paulirish Aug 11, 2022
3d7f84c
types
paulirish Aug 11, 2022
cdaf1b1
fix frame matching in responsiveness / work-during-interaction
paulirish Aug 11, 2022
7e4deda
cleanup
paulirish Aug 11, 2022
226f4bc
Revert "test: reformat trace fixtures"
paulirish Aug 11, 2022
74261f7
cleanup
paulirish Aug 11, 2022
fb8699a
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Dec 2, 2022
1dabd2d
add comment about EventTiming / FallbackTiming
paulirish Dec 2, 2022
bfea1c1
delete minify-trace as its unreliable
paulirish Dec 2, 2022
6b91487
some feedback from bckenny
paulirish Dec 2, 2022
7a6f743
renames. mainFrameIds => mainFrameInfo
paulirish Dec 2, 2022
6ddd040
fix no-FrameCommittedInBrowser case test
paulirish Dec 2, 2022
017ca53
add test for a pid-change trace. manually whittled down trace by drop…
paulirish Dec 2, 2022
c326c42
samplejson
paulirish Dec 2, 2022
a930350
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Dec 3, 2022
4704811
add warning about fallback case
paulirish Jan 10, 2023
5192b76
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Jan 10, 2023
8ea59db
minor
paulirish Jan 10, 2023
2c2f784
node id test. mostly comments. only fix is the frameID
paulirish Jan 10, 2023
6b3ac4f
toEqual -> toMatchObj
paulirish Jan 10, 2023
e1b56f5
revert all changes to computed/responsiveness
paulirish Jan 13, 2023
c01d309
apply connor's every() readability improvement. and add extra comments
paulirish Jan 13, 2023
d9e5118
samplejson - old trace, no more work-during-interaction results
paulirish Jan 13, 2023
b94a356
address nits form adam
paulirish Jan 13, 2023
b7d0579
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Jan 13, 2023
80d3fc9
typo
paulirish Jan 13, 2023
a5c6ff6
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Jan 25, 2023
6b5d706
cleanup w array.includes()
paulirish Jan 25, 2023
6cbf6cc
add metadata thread_name to all fixture traces, so we can loudly fail
paulirish Jan 25, 2023
4dee193
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Jan 25, 2023
917380e
lint
paulirish Jan 25, 2023
81a92b6
Merge remote-tracking branch 'origin/main' into processEventsfix
paulirish Jan 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/computed/metrics/responsiveness.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ class Responsiveness {
return evt.name === 'EventTiming' && evt.ph !== 'e';
});

if (candidates.length && !candidates.some(candidate => candidate.args.data?.frame)) {
paulirish marked this conversation as resolved.
Show resolved Hide resolved
// Full EventTiming data added in https://crrev.com/c/3632661
// If trace is from < m103, the timestamps cannot be trusted, so we craft a fallback
// <m103 traces (bad) had a args.frame
// m103+ traces (good) have a args.data.frame (https://crrev.com/c/3632661)
// TODO(compat): remove FallbackTiming handling when we don't care about <m103
if (candidates.length && candidates.every(candidate => !candidate.args.data?.frame)) {
return {
name: 'FallbackTiming',
duration: responsivenessEvent.args.data.maxDuration,
Expand Down
2 changes: 1 addition & 1 deletion core/computed/page-dependency-graph.js
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ class PageDependencyGraph {
* @return {URLArtifact}
*/
static getDocumentUrls(devtoolsLog, networkRecords, processedTrace) {
const mainFrameId = processedTrace.mainFrameIds.frameId;
const mainFrameId = processedTrace.mainFrameInfo.frameId;

/** @type {string|undefined} */
let requestedUrl;
Expand Down
172 changes: 0 additions & 172 deletions core/lib/minify-trace.js

This file was deleted.

Loading