Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(apple-touch-icon): remove audit #14243

Merged
merged 6 commits into from
Jul 28, 2022
Merged

core(apple-touch-icon): remove audit #14243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7469c02
core(apple-touch-icon): deprecate apple-touch-icon audit.
alexnj Jul 27, 2022
9b49b63
Update test definitions and flow.
alexnj Jul 27, 2022
ab858e3
more related items.
alexnj Jul 27, 2022
355bcbd
Replacement test for additive config filter test.
alexnj Jul 27, 2022
0cb39f4
Merge branch 'master' into apple-no-touch-icon
alexnj Jul 28, 2022
d742a2d
Update audit count in e2e tests.
alexnj Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions build/build-sample-reports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,6 @@ async function generateErrorLHR() {
offscreenImagesAudit.errorMessage = undefined;
offscreenImagesAudit.scoreDisplayMode = 'binary';
offscreenImagesAudit.score = 1;
// pwa-apple-touch-icon - set as passing but with a warning
const appleTouchIconAudit = errorLhr.audits['apple-touch-icon'];
appleTouchIconAudit.warnings = [
'`apple-touch-icon-precomposed` is out of date; `apple-touch-icon` is preferred.',
];
appleTouchIconAudit.errorMessage = undefined;
appleTouchIconAudit.scoreDisplayMode = 'binary';
appleTouchIconAudit.score = 1;

fs.rmSync(TMP, {recursive: true, force: true});
return errorLhr;
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-cli/test/smokehouse/test-definitions/pwa-airhorner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ const expectations = {
'content-width': {
score: 1,
},
'apple-touch-icon': {
score: 1,
},

// "manual" audits. Just verify in the results.
'pwa-cross-browser': {
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-cli/test/smokehouse/test-definitions/pwa-caltrain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ const expectations = {
'content-width': {
score: 1,
},
'apple-touch-icon': {
score: 1,
},

// "manual" audits. Just verify in the results.
'pwa-cross-browser': {
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-cli/test/smokehouse/test-definitions/pwa-chromestatus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ const expectations = {
'content-width': {
score: 1,
},
'apple-touch-icon': {
score: 1,
},

// "manual" audits. Just verify in the results.
'pwa-cross-browser': {
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-cli/test/smokehouse/test-definitions/pwa-rocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ const expectations = {
'content-width': {
score: 1,
},
'apple-touch-icon': {
score: 1,
},

// "manual" audits. Just verify in the results.
'pwa-cross-browser': {
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-cli/test/smokehouse/test-definitions/pwa-svgomg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ const expectations = {
'content-width': {
score: 1,
},
'apple-touch-icon': {
score: 1,
},

// "manual" audits. Just verify in the results.
'pwa-cross-browser': {
Expand Down
72 changes: 0 additions & 72 deletions lighthouse-core/audits/apple-touch-icon.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions lighthouse-core/config/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ const defaultConfig = {
'critical-request-chains',
'redirects',
'installable-manifest',
'apple-touch-icon',
'splash-screen',
'themed-omnibox',
'maskable-icon',
Expand Down Expand Up @@ -723,7 +722,6 @@ const defaultConfig = {
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
{id: 'viewport', weight: 2, group: 'pwa-optimized'},
{id: 'apple-touch-icon', weight: 1, group: 'pwa-optimized'},
{id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
// Manual audits
{id: 'pwa-cross-browser', weight: 0},
Expand Down
95 changes: 0 additions & 95 deletions lighthouse-core/test/audits/apple-touch-icon-test.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lighthouse-core/test/config/config-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,7 @@ describe('Config', () => {
extends: 'lighthouse:default',
settings: {
onlyCategories: ['pwa'],
onlyAudits: ['apple-touch-icon'],
onlyAudits: ['viewport'],
},
};
const config = await Config.fromJson(extended);
Expand Down
Loading