-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(devtools): use linux for CI #14199
Conversation
This would be nice but the NO_FCP stuff is way too common. Will need to investigate this before considering a merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of changes to the pptr-run-devtools.js
that should make the script more robust. I'm happy to split those out into a separate PR because it would benefit us on macos as well.
I tried to highlight the important changes in comments.
Saves us ~13mins on the build step
Before: https://github.com/GoogleChrome/lighthouse/actions/runs/2626494537
After: https://github.com/GoogleChrome/lighthouse/actions/runs/2666800793
Unfortunately, we're getting some flaky but very common NO_FCP errors in this branch.
We could also introduce a general
smoke-macos
job that runs CLI smokes just to cover all our bases.