Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add devtools e2e test runner #14110

Merged
merged 5 commits into from
Jun 22, 2022
Merged

tests: add devtools e2e test runner #14110

merged 5 commits into from
Jun 22, 2022

Conversation

connorjclark
Copy link
Collaborator

Pretty much the same structure as the webtests, but simpler. Re-uses some scripts from the webtests folder. Can re-org whenever we actually delete webtests.

Waiting on this to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3682120

@connorjclark connorjclark requested a review from a team as a code owner June 10, 2022 16:07
@connorjclark connorjclark requested review from brendankenny and paulirish and removed request for a team June 10, 2022 16:07
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure why you're using contentshell, but the e2e tests just use chromium in both local devtools dev and the devtools CI bots. doing that should allow us to delete some stuff :)

.github/workflows/devtools.yml Outdated Show resolved Hide resolved
lighthouse-core/scripts/roll-to-devtools.sh Show resolved Hide resolved
third-party/devtools-tests/README.md Show resolved Hide resolved
.github/workflows/devtools.yml Show resolved Hide resolved
@connorjclark
Copy link
Collaborator Author

Can't work out why the e2e job isn't able to get the build artifacts like the other jobs can...

image

@connorjclark
Copy link
Collaborator Author

Took awhile to wrangle CI stuff, making sure to only build DT the once. The trick was to zip the entire CDT directory in the shared build artifacts cache.

lighthouse-core/test/devtools-tests/setup.sh Outdated Show resolved Hide resolved
connorjclark and others added 2 commits June 22, 2022 15:47
Co-authored-by: Adam Raine <6752989+adamraine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants