core(devtools-log): consolidate implementation into gatherer #14080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Jun 3, 2022
connorjclark
reviewed
Jun 8, 2022
lighthouse-core/gather/driver.js
Outdated
| @@ -12,7 +12,7 @@ const {fetchResponseBodyFromCache} = require('../gather/driver/network.js'); | |||
| const EventEmitter = require('events').EventEmitter; | |||
|
|
|||
| const log = require('lighthouse-logger'); | |||
| const DevtoolsLog = require('./devtools-log.js'); | |||
| const DevToolsMessageLog = require('./gatherers/devtools-log.js').DevToolsMessageLog; | |||
There was a problem hiding this comment.
nit: casing does not match file/how we typically stylize "devtools"
connorjclark
reviewed
Jun 8, 2022
|
|
||
| /** | ||
| * This class saves all protocol messages whose method match a particular | ||
| * regex filter. Used when saving assets for later analysis by another tool such as |
There was a problem hiding this comment.
nit (sorry): spacing is off
connorjclark
reviewed
Jun 8, 2022
| module.exports = DevtoolsLog; | ||
| module.exports.DevToolsMessageLog = DevToolsMessageLog; |
There was a problem hiding this comment.
casing does not match
connorjclark
reviewed
Jun 8, 2022
|
|
||
| describe('DevtoolsLog', () => { | ||
| describe('DevToolsMessageLog', () => { |
connorjclark
approved these changes
Jun 8, 2022
connorjclark
changed the title
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we have two
devtools-log.jsfiles.the gatherer one is only used in FR, not legacy. in legacy, the equivalent functionality is done in driver.
so i'm changing the legacy one's name to be what it does. also… relevant 2017 threads: #1665 (comment) and #1669