clients(lr): run benchmark repeatedly given special query parameter #14075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Jun 2, 2022
connorjclark
reviewed
Jun 2, 2022
connorjclark
reviewed
Jun 2, 2022
| const bidxRunCount = options.settings.__internalMegaBenchmarkIndex; | ||
| // Keep the first one in there | ||
| const bidxes = [baseArtifacts.BenchmarkIndex]; | ||
| for (let i = 0; i < bidxRunCount; i++) { |
There was a problem hiding this comment.
It'd be simpler if the internal setting was just minus one'd here (And we asserted it either doesn't exist or is >= 1).
There was a problem hiding this comment.
as we're the only users i think this isn't a huge deal. and it'd complicate the impl
connorjclark
reviewed
Jun 2, 2022
connorjclark
reviewed
Jun 2, 2022
| if (options.settings.__internalMegaBenchmarkIndex) { | ||
| const bidxRunCount = options.settings.__internalMegaBenchmarkIndex; | ||
| // Keep the first one in there | ||
| const bidxes = [baseArtifacts.BenchmarkIndex]; |
There was a problem hiding this comment.
nit: bidxes -> indexes?
connorjclark
reviewed
Jun 2, 2022
| @@ -61,6 +61,11 @@ export async function runLighthouseInLR(connection, url, flags, lrOpts) { | |||
| config.settings.onlyCategories = categoryIDs; | |||
| } | |||
| } | |||
| // Set to 0 to disable | |||
There was a problem hiding this comment.
Set what to 0? Who is this comment for?
There was a problem hiding this comment.
Oh, I think I see. Could you instead make megaBidx be optional, or union with | false ?
There was a problem hiding this comment.
moved it to channel='fr' && queryParam('bidx') instead.
connorjclark
reviewed
Jun 2, 2022
|
I assume I can review this fine without understanding the motivation :) |
connorjclark
approved these changes
Jun 2, 2022
connorjclark
changed the title
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This weird mode is for some lightrider variance work underway.
Example output:
cc @adrianaixba