core: deprecate passes, remove config navigations from FR

[adamraine]

As discussed here, this PR removes config navigations (known as passes in legacy mode) from FR navigations.

There are some settings which are only configurable on a legacy pass/config navigation (e.g. pauseAfterFCPMs). I think it's better to define these on config.settings rather than maintain them in a half-deprecated state on config.passes.

[adamraine]

I didn't add any of these settings to config.settings because:

• disableStorageReset is already on config.settings
• id doesn't make sense if there is only one navigation
• disableThrottling can be achieved with config.settings.throttlingMethod = 'provided'
• config.artifacts is now the canonical list of artifacts, we don't need to maintain a second one

[adamraine]

This is actually a minor bug fix for timespan/snapshot because they weren't doing FPS as the final gatherer before.

[brendankenny]

This has more changes than I was picturing. I thought we were talking about moving the new default-config to basically the form you have it in this PR, but then config.js would internally convert it to the form it has today (creating a navigations array (or rename it passes), etc).

That would allow basically everything else to remain as it is today. More stuff to maintain, but fewer additional changes to get right before 10.0, leaves the door open to changing our mind on ditching passes, smoke tests still work, etc.

[adamraine]

I thought we were talking about moving the new default-config to basically the form you have it in this PR, but then config.js would internally convert it to the form it has today (creating a navigations array (or rename it passes), etc).

That's what I was looking into originally, the problem is what to do with the extra settings defined on each pass. It would leave passes in a weird half-deprecated state where we don't want users to use it with FR navigations but some of the settings still matter.

[brendankenny]

That's what I was looking into originally, the problem is what to do with the extra settings defined on each pass.

Can you give more specifics? Since it's only the config input, it seems like it wouldn't matter.

• If you use the new config format, it only supports the single navigation, so copying from the settings to (internally) create settings for a pass seems like it would be unambiguous.
• If you use the old config format, nothing changes

It would leave passes in a weird half-deprecated state where we don't want users to use it with FR navigations but some of the settings still matter.

Yeah, but passes will be in a weird half-deprecated state so that just matches what we're doing :)

[adamraine]

Can you give more specifics? Since it's only the config input, it seems like it wouldn't matter.

We would be telling users that passes are deprecated for the new config format, but if they want to configure something like cpuQuietThresholdMs then they would have to modify the passes on the config.

[brendankenny]

We would be telling users that passes are deprecated for the new config format, but if they want to configure something like cpuQuietThresholdMs then they would have to modify the passes on the config.

Oh, I thought we were discussing removing passes completely on the new config format, not just deprecating it. If someone needs passes they can use the deprecated classic config format for that. If they update to the new format cpuQuietThresholdMs would go on settings.

[adamraine]

Oh, I thought we were discussing removing passes completely on the new config format, not just deprecating it. If someone needs passes they can use the deprecated classic config format for that. If they update to the new format cpuQuietThresholdMs would go on settings.

Ok I think I was confused and got turned around. You don't have an issue with adding the pass settings to config.settings, you just want to create a fake internal navigation so we don't have to change everything. I think I'm on board with that.

[adamraine]

@brendankenny @connorjclark this should be ready for review