-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(fr): index test parity #13867
core(fr): index test parity #13867
Conversation
@connorjclark friendly ping |
@@ -327,6 +327,7 @@ async function navigationGather(requestor, options) { | |||
const artifacts = await Runner.gather( | |||
async () => { | |||
let {page} = options; | |||
const normalizedRequestor = isCallback ? requestor : URL.normalizeUrl(requestor); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, is this change necessary? it isn't even used until far down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, at least to match the legacy behavior. If the url is invalid, we should throw before attempting to connect to the page.
Follow up to #13865
I never copied some of the index tests for the new FR runner. This would have caught a few differences between the legacy runner and FR runner including #13863.
This PR brings back those tests for the FR runner.