report: set minimum width of element screenshot preview #13856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
connorjclark
changed the title
connorjclark
commented
Apr 14, 2022
| float: left; | ||
| margin-right: 20px; | ||
| } | ||
| .lh-element-screenshot__content { | ||
| overflow: hidden; | ||
| min-width: 110px; |
There was a problem hiding this comment.
hm... might wanna do min height too...
connorjclark
commented
Apr 14, 2022
| @@ -1745,15 +1745,18 @@ details[open] .lh-clump-toggletext--hide { display: block;} | |||
|
|
|||
| /* Element screenshot */ | |||
| .lh-element-screenshot { | |||
| position: relative; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
these didn't seem to do anything
connorjclark
commented
Apr 14, 2022
| @@ -253,9 +253,6 @@ export class ElementScreenshotRenderer { | |||
| {width: screenshot.width, height: screenshot.height} | |||
| ); | |||
|
|
|||
| const contentEl = dom.find('div.lh-element-screenshot__content', containerEl); | |||
| contentEl.style.top = `-${elementPreviewSizeDC.height}px`; | |||
There was a problem hiding this comment.
this didn't seem to do anything
adamraine
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes really tall elements look less bad in the screenshot element preview by giving it a minimum width and centering. Also much easier to click on now.
The marker and mask elements were being positioned relative to the image... so it makes more sense to have the
lh-element-screenshot__imageelement be the position: relative. This was necessary to make the outer content element center its contents correctly with a min-width / display flex / justify-content combo.Before
After