tests: fix smoke shard total in CI

[brendankenny]

#13792 relied on ${{ strategy.job-total }} for the count of total shards, but in the smoke tests the job-total is 6 from 3 shards * 2 versions of chrome. So we were accidentally testing half the smoke tests (shards 1/6, 2/6, and 3/6). You had to dig into the logs to see the problem, though the three minute completion times were suspicious :)

Also put the shard total in the job name so it's a little more prominent (though the name is still set manually, so there's no guarantee it'll be kept in sync with what's actually running).

[brendankenny]

Happy to change the wording here, as I assume it read like there is a solution (since the linked github discussion has an accepted solution), when really it was meant for background of the slightly different problem (multiple matrix dimensions) that isn't solved.

[brendankenny]

Also put the shard total in the job name so it's a little more prominent (though the name is still set manually, so there's no guarantee it'll be kept in sync with what's actually running).

I guess you aren't allowed to do that with env variables?

[connorjclark]

oops! yeah, I had assumed this problem was fixed.

will need to ensure the "these jobs must pass" form is correct in our repo settings when this lands

[brendankenny]

Also put the shard total in the job name so it's a little more prominent (though the name is still set manually, so there's no guarantee it'll be kept in sync with what's actually running).

I guess you aren't allowed to do that with env variables?

nope

https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability