Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: improve logging for devtools smoke runner #13781

Merged
merged 4 commits into from
Mar 30, 2022
Merged

tests: improve logging for devtools smoke runner #13781

merged 4 commits into from
Mar 30, 2022

Conversation

connorjclark
Copy link
Collaborator

  1. no more extraneous newlines
  2. actually retain the logging (the log variable the runner returns) on failure
  3. also log the initial building step (only relevant for local run)

@connorjclark connorjclark requested a review from a team as a code owner March 24, 2022 18:33
@connorjclark connorjclark requested review from adamraine and removed request for a team March 24, 2022 18:33
@connorjclark connorjclark merged commit 8fe8160 into master Mar 30, 2022
@connorjclark connorjclark deleted the smoke-dt-logs branch March 30, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @adamraine @devtools-bot