Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(service-worker): move to defaultPass, delete second pass #13711

Closed
wants to merge 7 commits into from

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Feb 28, 2022

Moves service-worker to the default pass, which allows us to delete the offline pass.

I thought offline-sw-broken would fail with this change. It didn't, but then I noticed there was no assertion on the actual service-worker audit. I manually verified that the result of that audit before/after this change remained the same–it passes. I suppose we don't at all handle the case of a "Broken" SW mishandling offline requests. There's some comments in the smoke test file re: a still-open chromium bug where the InstallabilityErrors artifacts may tell us this later. https://crbug.com/1187668#c22 I assume this feature, when it finally works again, will work even without a second pass.

Fixes #11822

@connorjclark connorjclark requested a review from a team as a code owner February 28, 2022 23:41
@connorjclark connorjclark requested review from adamraine and removed request for a team February 28, 2022 23:41
@@ -29,7 +29,7 @@ SKIP_DOWNLOADS=1 yarn test-devtools
```sh
curl https://bootstrap.pypa.io/pip/2.7/get-pip.py -o get-pip.py
python get-pip.py
pip -m pip install requests
python -m pip install requests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by fix

@adamraine
Copy link
Member

Can we eliminaate this smoke condition:

networkRequests: {
// Number of network requests differs between Fraggle Rock and legacy modes because
// FR has fewer passes, preserve this check moving forward.
_fraggleRockOnly: true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gather-runner: can we reduce to just one pass?
3 participants