-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(service-worker): move to defaultPass, delete second pass #13711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Mar 1, 2022
@@ -29,7 +29,7 @@ SKIP_DOWNLOADS=1 yarn test-devtools | |||
```sh | |||
curl https://bootstrap.pypa.io/pip/2.7/get-pip.py -o get-pip.py | |||
python get-pip.py | |||
pip -m pip install requests | |||
python -m pip install requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive by fix
adamraine
approved these changes
Mar 1, 2022
Can we eliminaate this smoke condition:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
service-worker
to the default pass, which allows us to delete the offline pass.I thought
offline-sw-broken
would fail with this change. It didn't, but then I noticed there was no assertion on the actualservice-worker
audit. I manually verified that the result of that audit before/after this change remained the same–it passes. I suppose we don't at all handle the case of a "Broken" SW mishandling offline requests. There's some comments in the smoke test file re: a still-open chromium bug where the InstallabilityErrors artifacts may tell us this later. https://crbug.com/1187668#c22 I assume this feature, when it finally works again, will work even without a second pass.Fixes #11822