tests: move readJson from root.js to test-utils.js (#14175)

build/build-bundle.js

@@ -21,7 +21,8 @@ import PubAdsPlugin from 'lighthouse-plugin-publisher-ads/plugin.js';
 
 import * as rollupPlugins from './rollup-plugins.js';
 import Runner from '../lighthouse-core/runner.js';
-import {LH_ROOT, readJson} from '../root.js';
+import {LH_ROOT} from '../root.js';
+import {readJson} from '../lighthouse-core/test/test-utils.js';
 
 const require = createRequire(import.meta.url);
 

build/build-extension.js

@@ -11,7 +11,8 @@ import cpy from 'cpy';
 import {rollup} from 'rollup';
 
 import * as rollupPlugins from './rollup-plugins.js';
-import {LH_ROOT, readJson} from '../root.js';
+import {LH_ROOT} from '../root.js';
+import {readJson} from '../lighthouse-core/test/test-utils.js';
 
 const argv = process.argv.slice(2);
 const browserBrand = argv[0];

build/build-sample-reports.js

@@ -15,7 +15,8 @@ import swapFlowLocale from '../shared/localization/swap-flow-locale.js';
 import ReportGenerator from '../report/generator/report-generator.js';
 import {defaultSettings} from '../lighthouse-core/config/constants.js';
 import lighthouse from '../lighthouse-core/index.js';
-import {LH_ROOT, readJson} from '../root.js';
+import {LH_ROOT} from '../root.js';
+import {readJson} from '../lighthouse-core/test/test-utils.js';
 
 /** @type {LH.Result} */
 const lhr = readJson(`${LH_ROOT}/lighthouse-core/test/results/sample_v2.json`);

build/gh-pages-app.js

@@ -14,7 +14,8 @@ import glob from 'glob';
 import * as terser from 'terser';
 
 import * as rollupPlugins from './rollup-plugins.js';
-import {LH_ROOT, readJson} from '../root.js';
+import {LH_ROOT} from '../root.js';
+import {readJson} from '../lighthouse-core/test/test-utils.js';
 
 const ghPagesDistDir = `${LH_ROOT}/dist/gh-pages`;
 const lighthousePackage = readJson(`${LH_ROOT}/package.json`);

lighthouse-cli/test/cli/bin-test.js

@@ -9,7 +9,8 @@ import fs from 'fs';
 import * as td from 'testdouble';
 import jestMock from 'jest-mock';
 
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../../lighthouse-core/test/test-utils.js';
 
 const mockRunLighthouse = jestMock.fn();
 const mockGetFlags = jestMock.fn();

lighthouse-cli/test/cli/printer-test.js

@@ -7,7 +7,7 @@
 import {strict as assert} from 'assert';
 import fs from 'fs';
 
-import {readJson} from '../../../root.js';
+import {readJson} from '../../../lighthouse-core/test/test-utils.js';
 import * as Printer from '../../printer.js';
 
 const sampleResults = readJson('../../../lighthouse-core/test/results/sample_v2.json', import.meta);

lighthouse-cli/test/smokehouse/report-assert-test.js

@@ -6,8 +6,8 @@
 
 /* eslint-disable no-control-regex */
 
+import {readJson} from '../../../lighthouse-core/test/test-utils.js';
 import {findDifferences, getAssertionReport} from './report-assert.js';
-import {readJson} from '../../../root.js';
 
 describe('findDiffersences', () => {
   const testCases = {

lighthouse-core/scripts/build-test-flow-report.js

@@ -11,7 +11,8 @@ import fs from 'fs';
 import open from 'open';
 
 import reportGenerator from '../../report/generator/report-generator.js';
-import {LH_ROOT, readJson} from '../../root.js';
+import {LH_ROOT} from '../../root.js';
+import {readJson} from '../test/test-utils.js';
 
 const flow = readJson('lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json');
 const htmlReport = reportGenerator.generateFlowReportHtml(flow);

lighthouse-core/scripts/i18n/bake-ctc-to-lhl.js

@@ -10,7 +10,8 @@
 import fs from 'fs';
 import path from 'path';
 
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 /**
  * @typedef CtcMessage

lighthouse-core/scripts/i18n/count-translated.js

@@ -8,7 +8,8 @@
 
 import glob from 'glob';
 
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 /** @type {LhlMessages} */
 const enUsLhl = readJson('shared/localization/locales/en-US.json');

lighthouse-core/scripts/i18n/prune-obsolete-lhl-messages.js

@@ -11,7 +11,8 @@ import glob from 'glob';
 import MessageParser from 'intl-messageformat-parser';
 
 import {collectAllCustomElementsFromICU} from '../../../shared/localization/format.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 /** @typedef {Record<string, {message: string}>} LhlMessages */
 

lighthouse-core/scripts/internal-analysis/analyze-issues.js

@@ -17,7 +17,7 @@
 
 import log from 'lighthouse-logger';
 
-import {readJson} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 /** @typedef {import('./download-issues.js').AugmentedGitHubIssue} AugmentedGitHubIssue */
 

lighthouse-core/scripts/lantern/assert-baseline-lantern-values-unchanged.js

@@ -14,7 +14,7 @@ import path from 'path';
 import chalk from 'chalk';
 
 import constants from './constants.js';
-import {readJson} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_WITH_COMPUTED_PATH;
 const HEAD_PATH = path.resolve(process.cwd(), INPUT_PATH);

lighthouse-core/scripts/lantern/debug-url.js

@@ -11,7 +11,8 @@ import path from 'path';
 import {execFileSync} from 'child_process';
 
 import constants from './constants.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const INPUT_URL = process.argv[2];
 if (!INPUT_URL) throw new Error('Usage $0: <url>');

lighthouse-core/scripts/lantern/print-correlations.js

@@ -19,7 +19,7 @@ import path from 'path';
 import chalk from 'chalk';
 
 import constants from './constants.js';
-import {readJson} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const GOOD_DIFF_AS_PERCENT_THRESHOLD = 0.2;
 const OK_DIFF_AS_PERCENT_THRESHOLD = 0.5;

lighthouse-core/scripts/lantern/run-on-all-assets.js

@@ -25,7 +25,8 @@ import path from 'path';
 import {execFileSync} from 'child_process';
 
 import constants from './constants.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_PATH;
 const SITE_INDEX_PATH = path.resolve(process.cwd(), INPUT_PATH);

lighthouse-core/scripts/lantern/run-once.js

@@ -11,7 +11,8 @@ import path from 'path';
 import PredictivePerf from '../../audits/predictive-perf.js';
 import Simulator from '../../lib/dependency-graph/simulator/simulator.js';
 import traceSaver from '../../lib/lantern-trace-saver.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 if (process.argv.length !== 4) throw new Error('Usage $0 <trace file> <devtools file>');
 

lighthouse-core/scripts/lantern/update-baseline-lantern-values.js

@@ -14,7 +14,8 @@ import {execFileSync} from 'child_process';
 import prettyJSONStringify from 'pretty-json-stringify';
 
 import constants from './constants.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const INPUT_PATH = process.argv[2] || constants.SITE_INDEX_WITH_GOLDEN_PATH;
 const SITE_INDEX_PATH = path.resolve(process.cwd(), INPUT_PATH);

lighthouse-core/scripts/legacy-javascript/examine-latest-run.js

@@ -22,7 +22,8 @@ import colors from 'colors';
 
 import LegacyJavascript from '../../audits/byte-efficiency/legacy-javascript.js';
 import format from '../../../shared/localization/format.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const LATEST_RUN_DIR = path.join(LH_ROOT, 'latest-run');
 

lighthouse-core/scripts/legacy-javascript/run.js

@@ -15,7 +15,8 @@ import glob from 'glob';
 import {makeHash} from './hash.js';
 import LegacyJavascript from '../../audits/byte-efficiency/legacy-javascript.js';
 import networkRecordsToDevtoolsLog from '../../test/network-records-to-devtools-log.js';
-import {LH_ROOT, readJson} from '../../../root.js';
+import {LH_ROOT} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const scriptDir = `${LH_ROOT}/lighthouse-core/scripts/legacy-javascript`;
 

lighthouse-core/scripts/release/bump-versions.js

@@ -8,7 +8,7 @@ import fs from 'fs';
 
 import glob from 'glob';
 
-import {readJson} from '../../../root.js';
+import {readJson} from '../../test/test-utils.js';
 
 const NEW_VERSION = process.argv[2];
 if (!/^\d+\.\d+\.\d+(-dev\.\d{8})?$/.test(NEW_VERSION)) {

lighthouse-core/test/audits/bootup-time-test.js

@@ -6,8 +6,8 @@
 
 import {strict as assert} from 'assert';
 
-import {readJson} from '../../../root.js';
 import BootupTime from '../../audits/bootup-time.js';
+import {readJson} from '../test-utils.js';
 
 const acceptableTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 const acceptableDevtoolsLogs = readJson('../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/byte-efficiency/byte-efficiency-audit-test.js

@@ -12,8 +12,7 @@ import CPUNode from '../../../lib/dependency-graph/cpu-node.js';
 import Simulator from '../../../lib/dependency-graph/simulator/simulator.js';
 import PageDependencyGraph from '../../../computed/page-dependency-graph.js';
 import LoadSimulator from '../../../computed/load-simulator.js';
-import {getURLArtifactFromDevtoolsLog} from '../../test-utils.js';
-import {readJson} from '../../../../root.js';
+import {getURLArtifactFromDevtoolsLog, readJson} from '../../test-utils.js';
 
 const trace = readJson('../../fixtures/traces/progressive-app-m60.json', import.meta);
 const devtoolsLog = readJson('../../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/byte-efficiency/duplicated-javascript-test.js

@@ -4,12 +4,12 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import DuplicatedJavascript from '../../../audits/byte-efficiency/duplicated-javascript.js';
 import {
   loadSourceMapFixture,
   createScript,
   getURLArtifactFromDevtoolsLog,
+  readJson,
 } from '../../test-utils.js';
 
 const trace = readJson('../../fixtures/traces/lcp-m78.json', import.meta);

lighthouse-core/test/audits/byte-efficiency/legacy-javascript-test.js

@@ -4,9 +4,9 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import LegacyJavascript from '../../../audits/byte-efficiency/legacy-javascript.js';
 import networkRecordsToDevtoolsLog from '../../network-records-to-devtools-log.js';
+import {readJson} from '../../test-utils.js';
 
 /**
  * @param {Array<{url: string, code: string, map?: LH.Artifacts.RawSourceMap}>} scripts

lighthouse-core/test/audits/byte-efficiency/render-blocking-resources-test.js

@@ -12,8 +12,7 @@ import NetworkNode from '../../../lib/dependency-graph/network-node.js';
 import CPUNode from '../../../lib/dependency-graph/cpu-node.js';
 import Simulator from '../../../lib/dependency-graph/simulator/simulator.js';
 import NetworkRequest from '../../../lib/network-request.js';
-import {getURLArtifactFromDevtoolsLog} from '../../test-utils.js';
-import {readJson} from '../../../../root.js';
+import {getURLArtifactFromDevtoolsLog, readJson} from '../../test-utils.js';
 
 const trace = readJson('../../fixtures/traces/progressive-app-m60.json', import.meta);
 const devtoolsLog = readJson('../../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/critical-request-chains-test.js

@@ -6,10 +6,10 @@
 
 import {strict as assert} from 'assert';
 
-import {readJson} from '../../../root.js';
 import CriticalRequestChains from '../../audits/critical-request-chains.js';
 import createTestTrace from '../create-test-trace.js';
 import networkRecordsToDevtoolsLog from '../network-records-to-devtools-log.js';
+import {readJson} from '../test-utils.js';
 
 const redditDevtoolsLog = readJson('../fixtures/artifacts/perflog/defaultPass.devtoolslog.json', import.meta);
 

lighthouse-core/test/audits/diagnostics-test.js

@@ -4,8 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../root.js';
 import Diagnostics from '../../audits/diagnostics.js';
+import {readJson} from '../test-utils.js';
 
 const acceptableTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 const acceptableDevToolsLog = readJson('../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/dobetterweb/uses-http2-test.js

@@ -4,11 +4,10 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import UsesHTTP2Audit from '../../../audits/dobetterweb/uses-http2.js';
 import NetworkRecords from '../../../computed/network-records.js';
 import networkRecordsToDevtoolsLog from '../../network-records-to-devtools-log.js';
-import {getURLArtifactFromDevtoolsLog} from '../../test-utils.js';
+import {getURLArtifactFromDevtoolsLog, readJson} from '../../test-utils.js';
 
 const trace = readJson('../../fixtures/traces/progressive-app-m60.json', import.meta);
 const devtoolsLog = readJson('../../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/final-screenshot-test.js

@@ -4,8 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../root.js';
 import FinalScreenshotAudit from '../../audits/final-screenshot.js';
+import {readJson} from '../test-utils.js';
 
 const pwaTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 

lighthouse-core/test/audits/installable-manifest-test.js

@@ -6,9 +6,9 @@
 
 import {strict as assert} from 'assert';
 
-import {readJson} from '../../../root.js';
 import InstallableManifestAudit from '../../audits/installable-manifest.js';
 import manifestParser from '../../lib/manifest-parser.js';
+import {readJson} from '../test-utils.js';
 
 const manifest = readJson('../fixtures/manifest.json', import.meta);
 const manifestDirtyJpg = readJson('../fixtures/manifest-dirty-jpg.json', import.meta);

lighthouse-core/test/audits/main-thread-tasks-test.js

@@ -4,8 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../root.js';
 import MainThreadTasks from '../../audits/main-thread-tasks.js';
+import {readJson} from '../test-utils.js';
 
 const acceptableTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 

lighthouse-core/test/audits/mainthread-work-breakdown-test.js

@@ -6,8 +6,8 @@
 
 import {strict as assert} from 'assert';
 
-import {readJson} from '../../../root.js';
 import PageExecutionTimings from '../../audits/mainthread-work-breakdown.js';
+import {readJson} from '../test-utils.js';
 
 const acceptableTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 const siteWithRedirectTrace = readJson('../fixtures/traces/site-with-redirect.json', import.meta);

lighthouse-core/test/audits/maskable-icon-test.js

@@ -4,9 +4,9 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../root.js';
 import MaskableIconAudit from '../../audits/maskable-icon.js';
 import manifestParser from '../../lib/manifest-parser.js';
+import {readJson} from '../test-utils.js';
 
 const manifest = readJson('../fixtures/manifest.json', import.meta);
 const manifestWithoutMaskable = readJson('../fixtures/manifest-no-maskable-icon.json', import.meta);

lighthouse-core/test/audits/metrics-test.js

@@ -6,10 +6,9 @@
 
 import jestMock from 'jest-mock';
 
-import {readJson} from '../../../root.js';
 import MetricsAudit from '../../audits/metrics.js';
 import TTIComputed from '../../computed/metrics/interactive.js';
-import {getURLArtifactFromDevtoolsLog} from '../test-utils.js';
+import {getURLArtifactFromDevtoolsLog, readJson} from '../test-utils.js';
 
 const pwaTrace = readJson('../fixtures/traces/progressive-app-m60.json', import.meta);
 const pwaDevtoolsLog = readJson('../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);

lighthouse-core/test/audits/metrics/cumulative-layout-shift-test.js

@@ -4,8 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import CumulativeLayoutShift from '../../../audits/metrics/cumulative-layout-shift.js';
+import {readJson} from '../../test-utils.js';
 
 const jumpyClsTrace = readJson('../../fixtures/traces/jumpy-cls-m90.json', import.meta);
 

lighthouse-core/test/audits/metrics/experimental-interaction-to-next-paint-test.js

@@ -4,9 +4,9 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import ExperimentalInteractionToNextPaint from
   '../../../audits/metrics/experimental-interaction-to-next-paint.js';
+import {readJson} from '../../test-utils.js';
 
 const interactionTrace = readJson('../../fixtures/traces/timespan-responsiveness-m103.trace.json', import.meta);
 const noInteractionTrace = readJson('../../fixtures/traces/jumpy-cls-m90.json', import.meta);

lighthouse-core/test/audits/metrics/first-contentful-paint-3g-test.js

@@ -4,9 +4,8 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import {readJson} from '../../../../root.js';
 import FCP3G from '../../../audits/metrics/first-contentful-paint-3g.js';
-import {getURLArtifactFromDevtoolsLog} from '../../test-utils.js';
+import {getURLArtifactFromDevtoolsLog, readJson} from '../../test-utils.js';
 
 const pwaTrace = readJson('../../fixtures/traces/progressive-app-m60.json', import.meta);
 const pwaDevtoolsLog = readJson('../../fixtures/traces/progressive-app-m60.devtools.log.json', import.meta);