misc: fix issues found in some strings from localizers (#14740)

GoogleChrome · Jan 31, 2023 · 3fd6637 · 3fd6637
1 parent 80cf54b
commit 3fd6637
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/core/audits/dobetterweb/doctype.js b/core/audits/dobetterweb/doctype.js
@@ -18,10 +18,10 @@ const UIStrings = {
     '[Learn more about the doctype declaration](https://developer.chrome.com/docs/lighthouse/best-practices/doctype/).',
   /** Explanatory message stating that the document has no doctype. */
   explanationNoDoctype: 'Document must contain a doctype',
-  /** Explanatory message stating that the document has wrong doctype */
-  explanationWrongDoctype: 'Document contains a doctype that triggers quirks-mode',
-  /** Explanatory message stating that the document has wrong doctype */
-  explanationLimitedQuirks: 'Document contains a doctype that triggers limited-quirks-mode',
+  /** Explanatory message stating that the document has wrong doctype that triggers `quirks-mode` */
+  explanationWrongDoctype: 'Document contains a `doctype` that triggers `quirks-mode`',
+  /** Explanatory message stating that the document has wrong doctype that triggers `limited-quirks-mode` */
+  explanationLimitedQuirks: 'Document contains a `doctype` that triggers `limited-quirks-mode`',
   /** Explanatory message stating that the publicId field is not empty. */
   explanationPublicId: 'Expected publicId to be an empty string',
   /** Explanatory message stating that the systemId field is not empty. */

diff --git a/core/lib/bf-cache-strings.js b/core/lib/bf-cache-strings.js
@@ -367,7 +367,7 @@ const UIStrings = {
       * @description Description text for not restored reason InjectedJavascript.
       */
   injectedJavascript:
-      'IPages that JavaScript is injected into by extensions are not currently eligible for back/forward cache.',
+      'Pages that JavaScript is injected into by extensions are not currently eligible for back/forward cache.',
   /**
       * @description Description text for not restored reason InjectedStyleSheet.
       */

diff --git a/core/scripts/i18n/collect-strings.js b/core/scripts/i18n/collect-strings.js
@@ -714,6 +714,8 @@ function checkKnownFixedCollisions(strings) {
       'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
       'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
       'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.',
+      'Document contains a $MARKDOWN_SNIPPET_0$ that triggers $MARKDOWN_SNIPPET_1$',
+      'Document contains a $MARKDOWN_SNIPPET_0$ that triggers $MARKDOWN_SNIPPET_1$',
       'Document has a valid $MARKDOWN_SNIPPET_0$',
       'Document has a valid $MARKDOWN_SNIPPET_0$',
       'Failing Elements',

diff --git a/core/test/audits/dobetterweb/doctype-test.js b/core/test/audits/dobetterweb/doctype-test.js
@@ -29,7 +29,7 @@ describe('DOBETTERWEB: doctype audit', () => {
     });
     assert.equal(auditResult.score, 0);
     expect(auditResult.explanation)
-        .toBeDisplayString('Document contains a doctype that triggers quirks-mode');
+        .toBeDisplayString('Document contains a `doctype` that triggers `quirks-mode`');
   });
 
   it('fails when document is in limited-quirks-mode', () => {
@@ -47,7 +47,7 @@ describe('DOBETTERWEB: doctype audit', () => {
     });
     assert.equal(auditResult.score, 0);
     expect(auditResult.explanation)
-        .toBeDisplayString('Document contains a doctype that triggers limited-quirks-mode');
+        .toBeDisplayString('Document contains a `doctype` that triggers `limited-quirks-mode`');
   });
 
   it('fails when the value of the name attribute is a value other than "html"', () => {

diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json
diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json