cli: remove --print-config (#14585)

GoogleChrome · Dec 6, 2022 · 2f67fbc · 2f67fbc
1 parent 3ccdb7a
commit 2f67fbc
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 515 deletions.
diff --git a/cli/bin.js b/cli/bin.js
@@ -27,11 +27,9 @@ import * as commands from './commands/commands.js';
 import * as Printer from './printer.js';
 import {getFlags} from './cli-flags.js';
 import {runLighthouse} from './run.js';
-import {generateConfig, generateLegacyConfig} from '../core/index.js';
 import {askPermission} from './sentry-prompt.js';
 import {LH_ROOT} from '../root.js';
 import {Sentry} from '../core/lib/sentry.js';
-import {getConfigDisplayString} from '../core/config/config.js';
 
 const pkg = JSON.parse(fs.readFileSync(LH_ROOT + '/package.json', 'utf-8'));
 
@@ -116,17 +114,6 @@ async function begin() {
     cliFlags.precomputedLanternData = data;
   }
 
-  if (cliFlags.printConfig) {
-    if (cliFlags.legacyNavigation) {
-      const config = await generateLegacyConfig(configJson, cliFlags);
-      process.stdout.write(config.getPrintString());
-    } else {
-      const config = await generateConfig(configJson, cliFlags);
-      process.stdout.write(getConfigDisplayString(config));
-    }
-    return;
-  }
-
   // By default, cliFlags.enableErrorReporting is undefined so the user is
   // prompted. This can be overriden with an explicit flag or by the cached
   // answer returned by askPermission().

diff --git a/cli/cli-flags.js b/cli/cli-flags.js
@@ -113,11 +113,6 @@ function getYargsParser(manualArgv) {
         default: false,
         describe: 'Prints a list of all required trace categories and exits',
       },
-      'print-config': {
-        type: 'boolean',
-        default: false,
-        describe: 'Print the normalized config for the given config and options, then exit.',
-      },
       'debug-navigation': {
         type: 'boolean',
         describe: 'Pause after page load to wait for permission to continue the run, evaluate `continueLighthouseRun` in the console to continue.',
@@ -212,7 +207,7 @@ function getYargsParser(manualArgv) {
       },
     })
     .group([
-      'save-assets', 'list-all-audits', 'list-locales', 'list-trace-categories', 'print-config', 'additional-trace-categories',
+      'save-assets', 'list-all-audits', 'list-locales', 'list-trace-categories', 'additional-trace-categories',
       'config-path', 'preset', 'chrome-flags', 'port', 'hostname', 'form-factor', 'screenEmulation', 'emulatedUserAgent',
       'max-wait-for-load', 'enable-error-reporting', 'gather-mode', 'audit-mode',
       'only-audits', 'only-categories', 'skip-audits', 'budget-path',
@@ -317,7 +312,7 @@ Example: --output-path=./lighthouse-results.html`,
       //   - We're just printing the config.
       //   - We're in auditMode (and we have artifacts already)
       // If one of these don't apply, if no URL, stop the program and ask for one.
-      const isPrintSomethingMode = argv.listAllAudits || argv.listLocales || argv.listTraceCategories || argv.printConfig;
+      const isPrintSomethingMode = argv.listAllAudits || argv.listLocales || argv.listTraceCategories;
       const isOnlyAuditMode = !!argv.auditMode && !argv.gatherMode;
       if (isPrintSomethingMode || isOnlyAuditMode) {
         return true;

diff --git a/cli/test/cli/__snapshots__/cli-flags-test.js.snap b/cli/test/cli/__snapshots__/cli-flags-test.js.snap
@@ -36,8 +36,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -78,8 +76,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -128,8 +124,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -170,8 +164,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -204,8 +196,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -252,8 +242,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -300,8 +288,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -348,8 +334,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -403,8 +387,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,
@@ -457,8 +439,6 @@ Object {
     "html",
   ],
   "port": 0,
-  "print-config": false,
-  "printConfig": false,
   "quiet": false,
   "save-assets": false,
   "saveAssets": false,