feat: Post Modify 기능 개발 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dl-00-e8
reviewed
Jan 29, 2024
| Post entity = postRepository.findById(id) | ||
| .orElseThrow(() -> new IllegalArgumentException()); | ||
| entity.modify(req); | ||
| entity.setModifiedAt(LocalDateTime.now()); |
There was a problem hiding this comment.
modifiedAt은 @LastModifiedAt이라는 어노테이션을 선언했기에, 이렇게 set 메소드를 쓰지 않아도 자동으로 시간이 업데이트될거라서 안 쓰셔도 될 거에요!
dl-00-e8
reviewed
Jan 29, 2024
| import org.springframework.data.annotation.CreatedDate; | ||
| import org.springframework.data.annotation.LastModifiedDate; | ||
| import org.springframework.data.jpa.domain.support.AuditingEntityListener; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| @Getter | ||
| @Setter |
There was a problem hiding this comment.
위의 setModifiedAt은 필요 없어서, setter도 사용 안 하셔도 될 것 같아요!
dl-00-e8
approved these changes
Jan 29, 2024
jinnxyoung
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)