Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qa 사항 업데이트 #143

Merged
merged 6 commits into from
May 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ public interface ApplyRepository extends JpaRepository<Apply,Long> {

Page<Apply> findAllByPost(Post post, Pageable pageable);

Page<Apply> findApplyByApplyTypeAndMember(ApplyType applyType, Member member, Pageable pageable);
Page<Apply> findApplyByApplyTypeAndMemberAndIsCanceledFalse(ApplyType applyType, Member member, Pageable pageable);

List<Apply> findAllByMemberAndDeletedAtIsNull(Member member);
List<Apply> findAllByMemberAndDeletedAtIsNullOrderByCreatedAtDesc(Member member);

Apply findApplyByMemberAndPost(Member member,Post post);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ public ApplyPageRes applyListPage(Member member, long postId, int page, int size

public ParticipationPageRes myParticipationPostListPage(Member member,int page, int size) {
Pageable pageable = PageRequest.of(page, size, Sort.by(Sort.Direction.DESC, "createdAt"));
Page<Apply> participationPage = applyRepository.findApplyByApplyTypeAndMember(ApplyType.PASS,member,pageable);
Page<Apply> participationPage = applyRepository.findApplyByApplyTypeAndMemberAndIsCanceledFalse(ApplyType.PASS,member,pageable);
List<ParticipationList> participationLists = participationPage.getContent().stream()
.filter(apply -> apply.getPost().getStatus().equals(PostStatus.ACTIVE))
.filter(apply -> apply.getPost().getStatus().equals(PostStatus.ACTIVE) || apply.getPost().getStatus().equals(PostStatus.COMPLETE))
.map(apply -> ParticipationList.of(apply.getPost(), CategoryType.valueOf(apply.getRecruit_part())))
.collect(Collectors.toList());
int pageNo = participationPage.getNumber();
Expand Down Expand Up @@ -262,7 +262,7 @@ public List<MyPageRes> getMyApplyList(Member member) {
// Validation

// Business Logic
List<Apply> applyList = applyRepository.findAllByMemberAndDeletedAtIsNull(member);
List<Apply> applyList = applyRepository.findAllByMemberAndDeletedAtIsNullOrderByCreatedAtDesc(member);


// Response
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.gongjakso.server.domain.post.controller;

import com.gongjakso.server.domain.apply.service.ApplyService;
import com.gongjakso.server.domain.post.dto.*;
import com.gongjakso.server.domain.post.service.PostService;
import com.gongjakso.server.global.common.ApplicationResponse;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public enum PostStatus {
CANCEL("모집 취소"),
CLOSE("모집 마감"),
ACTIVE("활동 중"),
COMPLETE("모집 완료"),
COMPLETE("활동 완료"),
EXTENSION("모집 연장");

private final String status;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,5 @@ public interface PostRepository extends JpaRepository<Post, Long> {
Page<Post> findAllPostsJoinedWithStackNamesByTitleContainsAndPostTypeTrueAndDeletedAtIsNullAndFinishDateAfterAndStatusAndMeetingCityContainsAndMeetingTownContainsAndStackNamesStackNameTypeContainsOrderByScrapCountDescPostIdDesc
(@Param("searchWord") String searchWord, @Param("currentTimestamp") LocalDateTime currentTimestamp, @Param("status") PostStatus status, @Param("meetingCity") String meetingCity, @Param("meetingTown") String meetingTown, @Param("stackNameType") String stackNameType,Pageable pageable);

List<Post> findAllByMemberAndStatusAndDeletedAtIsNull(Member member, PostStatus status);
List<Post> findAllByMemberAndStatusAndDeletedAtIsNullOrderByCreatedAtDesc(Member member, PostStatus status);
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
import com.gongjakso.server.global.security.PrincipalDetails;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageImpl;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Pageable;
import org.springframework.data.domain.*;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

Expand Down Expand Up @@ -144,7 +141,7 @@ public PostDeleteRes delete(Member member, Long id) {
*/
@Transactional
public Page<GetContestRes> getContests(String sort, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
Page<Post> posts;
if(sort.equals("createdAt")){ //최신순
posts = postRepository.findAllByPostTypeFalseAndDeletedAtIsNullAndFinishDateAfterAndStatusOrderByPostIdDesc(LocalDateTime.now(), RECRUITING, pageable);
Expand All @@ -162,7 +159,7 @@ public Page<GetContestRes> getContests(String sort, Pageable page) throws Applic
*/
@Transactional
public Page<GetContestRes> getContestsBySearchWord(String sort, String searchWord, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
Page<Post> posts;
if (sort.equals("createdAt")) {
posts = postRepository.findAllByTitleContainsAndPostTypeFalseAndDeletedAtIsNullAndFinishDateAfterAndStatusOrderByPostIdDesc(searchWord.toLowerCase(), LocalDateTime.now(), RECRUITING, pageable);
Expand All @@ -181,7 +178,7 @@ public Page<GetContestRes> getContestsBySearchWord(String sort, String searchWor
@Transactional
public Page<GetContestRes> getContestsByMeetingAreaAndCategoryAndSearchWord(
String sort, String meetingCity, String meetingTown, String category, String searchWord, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
if(meetingTown.equals("전체")){
meetingTown = "";
}
Expand Down Expand Up @@ -216,7 +213,7 @@ public Page<GetContestRes> getContestsByMeetingAreaAndCategoryAndSearchWord(
*/
@Transactional
public Page<GetProjectRes> getProjects(String sort, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
Page<Post> posts;
if(sort.equals("createdAt")){ //최신순
posts = postRepository.findAllByPostTypeTrueAndDeletedAtIsNullAndFinishDateAfterAndStatusOrderByPostIdDesc(LocalDateTime.now(), RECRUITING, pageable);
Expand All @@ -233,7 +230,7 @@ public Page<GetProjectRes> getProjects(String sort, Pageable page) throws Applic
*/
@Transactional
public Page<GetProjectRes> getProjectsBySearchWord(String sort, String searchWord, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
Page<Post> posts;
if (sort.equals("createdAt")) {
posts = postRepository.findAllByTitleContainsAndPostTypeTrueAndDeletedAtIsNullAndFinishDateAfterAndStatusOrderByPostIdDesc(searchWord.toLowerCase(), LocalDateTime.now(), RECRUITING, pageable);
Expand All @@ -251,7 +248,7 @@ public Page<GetProjectRes> getProjectsBySearchWord(String sort, String searchWor
@Transactional
public Page<GetProjectRes> getProjectsByMeetingAreaAndStackNameAndSearchWord(
String sort, String meetingCity, String meetingTown, String stackName, String searchWord, Pageable page) throws ApplicationException {
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));
if(meetingTown.equals("전체")){
meetingTown = "";
}
Expand Down Expand Up @@ -338,7 +335,7 @@ public List<MyPageRes> getMyPostList(Member member) {
// Validation

// Business Logic
List<Post> postList = postRepository.findAllByMemberAndStatusAndDeletedAtIsNull(member, RECRUITING);
List<Post> postList = postRepository.findAllByMemberAndStatusAndDeletedAtIsNullOrderByCreatedAtDesc(member, RECRUITING);

// Return
return postList.stream()
Expand Down Expand Up @@ -374,7 +371,7 @@ public GetPostRelation checkPostRelation(Member member, Long postId) {

@Transactional
public Page<GetProjectRes> getMyScrapProject(Member member, Pageable page){
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));

Page<PostScrap> scrapPageList = postScrapRepository.findAllByMemberAndScrapStatusTrueOrderByPostScrapIdDesc(member, pageable);

Expand All @@ -401,7 +398,7 @@ public Page<GetProjectRes> getMyScrapProject(Member member, Pageable page){

@Transactional
public Page<GetContestRes> getMyScrapContest(Member member, Pageable page){
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize());
Pageable pageable = PageRequest.of(page.getPageNumber(), page.getPageSize(), Sort.by(Sort.Order.desc("created_at")));

Page<PostScrap> scrapPageList = postScrapRepository.findAllByMemberAndScrapStatusTrueOrderByPostScrapIdDesc(member, pageable);

Expand Down
Loading