Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ Feat/NewApplicationUI#271[μ§€μ›μ„œμ™€ 포폴 νŽ˜μ΄μ§€ κ΅¬ν˜„] #274

Merged
merged 7 commits into from
Sep 30, 2024
Merged

πŸ”€ Feat/NewApplicationUI#271[μ§€μ›μ„œμ™€ 포폴 νŽ˜μ΄μ§€ κ΅¬ν˜„] #274

merged 7 commits into from
Sep 30, 2024

Conversation

Herrypi
Copy link
Contributor

@Herrypi Herrypi commented Sep 30, 2024 •
edited
Loading

PR ν…œν”Œλ¦Ώ

체크리슀트!

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?
  • πŸ’­ μ΄μŠˆλŠ” λ“±λ‘ν–ˆλ‚˜μš”?
  • 🏷️ 라벨은 λ“±λ‘ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μ—­

  1. μ§€μ›μ„œ 보기 클릭 μ‹œ μƒˆλ‘œμš΄ 창으둜 μ§€μ›μ„œ λ‚΄μš©κ³Ό 포폴이 보이게 κ΅¬ν˜„

ν”Όλ“œλ°±μ„ λ°›κ³  싢은 λΆ€λΆ„

  1. μ§€μ›μ„œ 보기 클릭 μ‹œ μƒˆλ‘œμš΄ 창으둜 μ§€μ›μ„œ λ‚΄μš©κ³Ό 포폴이 λ³΄μ΄λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  2. 포폴을 μΆ”κ°€ν–ˆμ„ λ•Œμ™€ μΆ”κ°€ν•˜μ§€ μ•Šμ•˜μ„ 경우 νŽ˜μ΄μ§€κ°€ λ‹€λ₯΄κ²Œ λ³΄μ΄λŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”

PR 특이 사항

  1. pdf λ‹€μš΄ λ²„νŠΌμ€ λ””μžμΈ μΆ”κ°€ ν›„ μ μš©μ˜ˆμ •μž…λ‹ˆλ‹€.
  2. npm install --save html2pdf.js@0.9.3 진행 ν›„ ν™•μΈν•΄μ£Όμ„Έμš”

특이 사항 :

Issue Number: #271

close: #271

sseuldev and others added 7 commits September 30, 2024 03:07
@sseuldev
πŸ’„ Add Application Info
44435c7 
#271 지원뢄야, μ§€μ›μ΄μœ  UI μ™„λ£Œ
@sseuldev
πŸ’„ Add portfolio box UI
a7063d9 
#271 μ§€μ›μ„œ 양식 κΈ°λ³Έν‹€ μ™„μ„±
@Herrypi
✨ Add PDF download κΈ°λŠ₯
97b46c9 
#271 μ§€μ›μ„œ PDF λ‹€μš΄ κΈ°λŠ₯ μΆ”κ°€
@sseuldev @Herrypi
πŸ’„ Add Application Info
bc36fe6
@sseuldev @Herrypi
πŸ’„ Add portfolio box UI
63689fe 
#271 μ§€μ›μ„œ 양식 κΈ°λ³Έν‹€ μ™„μ„±
@Herrypi
✨ Add PDF download κΈ°λŠ₯
c8659d3 
#271 μ§€μ›μ„œ PDF λ‹€μš΄ κΈ°λŠ₯ μΆ”κ°€
@Herrypi
Merge branch 'Feat/NewApplicationUI#271' of https://github.com/Gongja…
69f1997 
…kso/web into Feat/NewApplicationUI#271
sxxcxng
sxxcxng approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@sxxcxng sxxcxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 μž‘λ™λ©λ‹ˆλ‹€!

@Herrypi Herrypi merged commit 7804920 into develop Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxxcxng sxxcxng sxxcxng approved these changes

Assignees

@Herrypi Herrypi

@sseuldev sseuldev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Herrypi @sxxcxng @sseuldev