Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ Refactor/ComponentSize#252 [λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆ μˆ˜μ •] #255

Merged
merged 1 commit into from
Sep 23, 2024
Merged

πŸ”€ Refactor/ComponentSize#252 [λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆ μˆ˜μ •] #255

merged 1 commit into from
Sep 23, 2024

Conversation

chaeyoungwon
Copy link
Member

PR ν…œν”Œλ¦Ώ

체크리슀트!

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?
  • πŸ’­ μ΄μŠˆλŠ” λ“±λ‘ν–ˆλ‚˜μš”?
  • 🏷️ 라벨은 λ“±λ‘ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μ—­

  1. λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆ μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€

ν”Όλ“œλ°±μ„ λ°›κ³  싢은 λΆ€λΆ„

  1. λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆκ°€ μ μ ˆν•œμ§€ ν™•μΈλΆ€νƒλ“œλŸ¬μš”

PR 특이 사항

특이 사항 :

Issue Number: #252

close: #252

@chaeyoungwon
πŸ’„ Update Component Size
ba15ada 
#252 λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆ μˆ˜μ •
@chaeyoungwon chaeyoungwon added the πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation label Sep 23, 2024
@chaeyoungwon chaeyoungwon self-assigned this Sep 23, 2024
@chaeyoungwon chaeyoungwon changed the base branch from main to develop September 23, 2024 11:07
@netlify Netlify
Copy link

netlify bot commented Sep 23, 2024 •
edited
Loading

βœ… Deploy Preview for gongjakso ready!

Name Link
πŸ”¨ Latest commit ba15ada
πŸ” Latest deploy log https://app.netlify.com/sites/gongjakso/deploys/66f14bcec6c5c90008d6b906
😎 Deploy Preview https://deploy-preview-255--gongjakso.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sxxcxng
sxxcxng approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@sxxcxng sxxcxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!

@chaeyoungwon chaeyoungwon merged commit f0ea648 into develop Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxxcxng sxxcxng sxxcxng approved these changes

Assignees

@chaeyoungwon chaeyoungwon

Labels
πŸ™†πŸ»β€β™€οΈ κ΅¬ν˜„ μ™„λ£Œ Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

♻️ λ©”μΈνŽ˜μ΄μ§€ μ»΄ν¬λ„ŒνŠΈ μ‚¬μ΄μ¦ˆ μ‘°μ •
2 participants
@chaeyoungwon @sxxcxng