-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library updates, include FlameLeviathan bonus itemlevels + Herald Check in character sheet #246
Conversation
tooltip hint on LFG send button use libgearscore's existing cache for average itemlevel
Let's do this without the Tooltip changes. The {rt3} Looks ugly in the tooltip. Nobody should ever see that written that way. @TannerShmoog @Road-block |
Also what is the "Leviathan 91" I don't get the 91 part. Let's leave Levithan and Herald out... seems like something that's better left to weak auras. |
91 is the itemlevels above baseline for vehicles. The players that care about optimizing for vehicle encounters (like Flame Leviathan) will know what it represents. 😄 |
About the tooltip hint. The first time I hit it I thought it was going to do a |
I am just explaining the motivation btw, I'm fine with cherry picking anything that aligns with the design and leaving other stuff out 👍🏻 |
It's fine, you're probably the last person left using this. Might as well get what you want. (= Beggars can't be choosers. There's stuff I wouldn't agree with, but at the end of the day however it gets done, it gets done. I'm not helping this add-on sticking around. |
% are better. And it's all vehicles, so better to say "vehicle" vs leviathan. So like drakes in Occ, and Eye. Yeah? |
…erically attempt to prettify the tooltip hint on the LFG button
…t noteworthy changes` update popup
change send message button label to better reflect its function
As seen on the commit list for this pull request it already includes the work done in develop branch by Tanner up to this point.
Additions on top of that include