Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory and speed up assignGeneId from issue #368 #372

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

andredsim
Copy link
Collaborator

No longer creates the large expandedRanges object that caused crashes with large data sets
Speed up the function by removing the arrange

@codecov-commenter
Copy link

Codecov Report

Merging #372 (b5f6a61) into devel (2712db5) will decrease coverage by 0.12%.
The diff coverage is 64.00%.

❗ Current head b5f6a61 differs from pull request most recent head cd927f0. Consider uploading reports for the commit cd927f0 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##            devel     #372      +/-   ##
==========================================
- Coverage   86.42%   86.30%   -0.12%     
==========================================
  Files          24       24              
  Lines        3220     3221       +1     
==========================================
- Hits         2783     2780       -3     
- Misses        437      441       +4     
Impacted Files Coverage Δ
R/bambu-processReads_utilityConstructReadClasses.R 91.73% <64.00%> (-1.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andredsim andredsim merged commit 1c1900e into devel Jul 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants