Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incident details option for json and sarif formats #956

Conversation

fnareoh
Copy link
Collaborator

@fnareoh fnareoh commented Sep 6, 2024

Context

  • Add --with-incident-details to output (json and sarif output only) more information about incident when the secret is already known by the gitguardian dashboard.

What has been done

Validation

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@fnareoh fnareoh self-assigned this Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (ee57c1a) to head (0511b73).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...gshield/verticals/secret/secret_scan_collection.py 87.50% 2 Missing ⚠️
ggshield/core/errors.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   91.65%   91.70%   +0.04%     
==========================================
  Files         178      178              
  Lines        7383     7422      +39     
==========================================
+ Hits         6767     6806      +39     
  Misses        616      616              
Flag Coverage Δ
unittests 91.70% <95.08%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fnareoh fnareoh force-pushed the garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity branch from 6f4eead to 383688e Compare September 10, 2024 14:05
@fnareoh fnareoh force-pushed the garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity branch from 383688e to 7e7c1cb Compare September 13, 2024 08:32
@fnareoh fnareoh force-pushed the garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity branch from 7e7c1cb to 2105800 Compare September 13, 2024 14:52
@fnareoh fnareoh force-pushed the garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity branch from 2105800 to 0511b73 Compare September 16, 2024 09:14
@fnareoh fnareoh merged commit 07394e1 into main Sep 18, 2024
28 checks passed
@fnareoh fnareoh deleted the garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity branch September 18, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants