-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add incident details option for json and sarif formats #956
Merged
fnareoh
merged 1 commit into
main
from
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
Sep 18, 2024
Merged
Add incident details option for json and sarif formats #956
fnareoh
merged 1 commit into
main
from
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 91.65% 91.70% +0.04%
==========================================
Files 178 178
Lines 7383 7422 +39
==========================================
+ Hits 6767 6806 +39
Misses 616 616
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
agateau-gg
requested changes
Sep 9, 2024
ggshield/verticals/secret/output/secret_sarif_output_handler.py
Outdated
Show resolved
Hide resolved
...log.d/20240906_141336_fnareoh_scrt_4693_ggshield_output_expose_incident_date_and_severity.md
Outdated
Show resolved
Hide resolved
fnareoh
force-pushed
the
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
branch
from
September 10, 2024 14:05
6f4eead
to
383688e
Compare
agateau-gg
requested changes
Sep 12, 2024
fnareoh
force-pushed
the
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
branch
from
September 13, 2024 08:32
383688e
to
7e7c1cb
Compare
agateau-gg
requested changes
Sep 13, 2024
fnareoh
force-pushed
the
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
branch
from
September 13, 2024 14:52
7e7c1cb
to
2105800
Compare
agateau-gg
approved these changes
Sep 13, 2024
fnareoh
force-pushed
the
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
branch
from
September 16, 2024 09:14
2105800
to
0511b73
Compare
fnareoh
deleted the
garancegourdel/scrt-4693-ggshield-output-expose-incident-date-and-severity
branch
September 18, 2024 16:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
--with-incident-details
to output (json and sarif output only) more information about incident when the secret is already known by the gitguardian dashboard.What has been done
Validation
PR check list
skip-changelog
label has been added to the PR.