Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cbouchard/ /merge branches #586

Merged
merged 20 commits into from
Jun 27, 2023
Merged

Cbouchard/ /merge branches #586

merged 20 commits into from
Jun 27, 2023

Conversation

cyrvan-b
Copy link
Contributor

@cyrvan-b cyrvan-b commented Jun 26, 2023

Merge main into main-iac.

agateau-gg and others added 19 commits June 14, 2023 10:40
…elps_and_error

docs(honeytoken): Honeytoken improve help textes and error
A new maximum lifetime setting is coming for business workspaces. With
this setting, managers can set a maximum lifetime for personal access
tokens.

When a token is created with a lifetime above this limit, its expiration
date is downsized to respect the workspace setting. THen, a warning
message is added to the login output to inform the user.

Changelog: skip
…x_lifetime_tokens

feat(oauth): #COR-1425 Support max lifetime on access tokens
@cyrvan-b cyrvan-b force-pushed the cbouchard/-/merge_branches branch 3 times, most recently from 2873da7 to fe51eaa Compare June 26, 2023 13:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #586 (9669d79) into main-iac (2edc385) will increase coverage by 0.18%.
The diff coverage is 94.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           main-iac     #586      +/-   ##
============================================
+ Coverage     93.73%   93.91%   +0.18%     
============================================
  Files            93      104      +11     
  Lines          4163     4653     +490     
============================================
+ Hits           3902     4370     +468     
- Misses          261      283      +22     
Flag Coverage Δ
unittests 93.91% <94.67%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ggshield/iac/iac_scan_models.py 84.09% <50.00%> (-1.63%) ⬇️
...gshield/iac/collection/iac_diff_scan_collection.py 85.71% <66.66%> (-14.29%) ⬇️
ggshield/hmsl/utils.py 81.25% <81.25%> (ø)
ggshield/cmd/hmsl/decrypt.py 90.74% <90.74%> (ø)
ggshield/cmd/hmsl/check.py 92.50% <92.50%> (ø)
ggshield/cmd/hmsl/query.py 94.59% <94.59%> (ø)
ggshield/core/config/config.py 95.57% <97.22%> (+0.70%) ⬆️
ggshield/hmsl/client.py 97.77% <97.77%> (ø)
ggshield/cmd/hmsl/__init__.py 100.00% <100.00%> (ø)
ggshield/cmd/hmsl/api_status.py 100.00% <100.00%> (ø)
... and 20 more

... and 1 file with indirect coverage changes

@cyrvan-b cyrvan-b requested review from GG-HH and removed request for GG-HH June 26, 2023 13:45
@cyrvan-b cyrvan-b closed this Jun 26, 2023
@cyrvan-b cyrvan-b reopened this Jun 26, 2023
@cyrvan-b cyrvan-b requested a review from GG-HH June 26, 2023 15:11
@GG-HH GG-HH merged commit bf6d460 into main-iac Jun 27, 2023
47 checks passed
@GG-HH GG-HH deleted the cbouchard/-/merge_branches branch June 27, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants