Update jobs to push ggshield formula on both GitGuardian's taps #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau-gg
reviewed
Nov 24, 2021
agateau-gg
reviewed
Nov 24, 2021
pierrelalanne
force-pushed
the
plalanne/-/handle-new-homebrew-tap
branch
from
a7a65a7
to
4bac2dd
Compare
|
Thanks for the review Aurélien, should be better now. |
agateau-gg
approved these changes
Nov 25, 2021
jeremyds
reviewed
Nov 25, 2021
.github/workflows/tag.yml
Outdated
| - name: Checkout Homebrew-ggshield | ||
| uses: actions/checkout@master | ||
| with: | ||
| repository: GitGuardian/homebrew-ggshield | ||
| token: ${{ secrets.PAT_GITHUB }} | ||
| path: ./brew | ||
| path: ./ggshield |
There was a problem hiding this comment.
I am surprised, don't you want to checkout it in the brew directory like it was done before?
There was a problem hiding this comment.
We checkout this repo to ./ggshield now.
There was a problem hiding this comment.
there is already a ggshield directory in the repo root, don't you want to use another non existent one?
There was a problem hiding this comment.
Should be good now.
pierrelalanne
force-pushed
the
plalanne/-/handle-new-homebrew-tap
branch
from
4bac2dd
to
911c722
Compare
pierrelalanne
force-pushed
the
plalanne/-/handle-new-homebrew-tap
branch
from
911c722
to
d8ee302
Compare
jeremyds
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In this MR, we want to lay the ground for migrating to a central tap for all GitGuardian's tool.
What we did
This MR simply modifies the
tagworkflow to push ggshield formula to two taps.Warning : We should wait for
GitGuardian/homebrew-tapto be public before merging.