Modernize doc examples to use idiomatic Rust #62
Conversation
|
Ok, doesn't pass CI. WDYT about switching to 1.31 as MSRV (and adding |
|
Is it possible to not run doctests in earlier targets, or does this require e2018? |
|
That's also possible, see the last commit. I guess in a sense that is better -- you want to show-case modern Rust in docs, even if you support something very old. Although, practically speaking, bumping to 2018 edition seems OK given that we already have 2021 |
|
FYI, there's a per-repository, non-default setting to make this better:
|
|
Good idea. Though iirc you're not even a first time contributer(?). WRT edition, you're essentially right, I can't imagine someone wanting to upgrade memoffset and not rustc, seeing as most benefits come from extremely new versions of rustc. Will be done at some point, I think, I'll have to think about it a bit |
|
Also, thank you :) |
| run: cargo test | ||
| # Exclude doctests here, as we don't want to clutter docs themselves | ||
| # with backwards compatibility workarounds. | ||
| run: cargo test --lib |
There was a problem hiding this comment.
Some of the versions in the list above should still work here, would it be possible to still run the full test suite for them?
Also, stable/beta/nightly now are tested twice for no good reason.
I'd be strongly opposed to that unless all our reverse dependencies already have a higher MSRV, but it seems you managed to avoid it. :) |
No description provided.