Fix rnum=0 causing integer overflow in SoB volume

rnum-1 is passed into RandomPointGenerator::apply a few lines later
GeomScale · Jun 30, 2022 · 9809695 · 9809695
1 parent 59cd27e
commit 9809695
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/include/volume/volume_sequence_of_balls.hpp b/include/volume/volume_sequence_of_balls.hpp
@@ -81,7 +81,8 @@ double volume_sequence_of_balls(Polytope const& Pin,
     P.shift(c.getCoefficients());
     c = Point(n);
 
-    rnum = rnum/n_threads;
+    // Scale by number of threads and prevent edge case rnum=0 from producing overflow later
+    rnum = rnum >= n_threads ? rnum/n_threads : 1u;
     NT vol = NT(0);
 
     // Perform the procedure for a number of threads and then take the average